Re: [PATCH net-next v2] net: ethernet: mediatek: Fix overlapping capability bits.

2019-07-04 Thread David Miller
From: René van Dorst Date: Wed, 3 Jul 2019 20:42:04 +0200 > Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. > > This can causes issues on non-MT7621 devices which has the > MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) and MTK_TRGMII capability set. > The wrong TRGMII setup code can

[PATCH net-next v2] net: ethernet: mediatek: Fix overlapping capability bits.

2019-07-03 Thread René van Dorst
Both MTK_TRGMII_MT7621_CLK and MTK_PATH_BIT are defined as bit 10. This can causes issues on non-MT7621 devices which has the MTK_PATH_BIT(MTK_ETH_PATH_GMAC1_RGMII) and MTK_TRGMII capability set. The wrong TRGMII setup code can be executed. The current wrongly executed code doesn’t do any harm on