Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 12:09:06 +0100 you wrote: > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > immediately. Shouldn't store a pointer to freed memory. > > Signed-off-by: Christian Eggers > Fixes:

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 23:04:36 +0200 Vladimir Oltean wrote: > On Fri, Nov 20, 2020 at 12:59:21PM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 20:01:49 +0200 Vladimir Oltean wrote: > > > On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > > > > If dsa_switch_ops::port_txtst

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Vladimir Oltean
On Fri, Nov 20, 2020 at 12:59:21PM -0800, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 20:01:49 +0200 Vladimir Oltean wrote: > > On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > > > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > > > immediately. Shouldn't

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 20:01:49 +0200 Vladimir Oltean wrote: > On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > > immediately. Shouldn't store a pointer to freed memory. > > > > Signed-off-by: Christian Egger

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Florian Fainelli
On 11/19/20 3:09 AM, Christian Eggers wrote: > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > immediately. Shouldn't store a pointer to freed memory. > > Signed-off-by: Christian Eggers > Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX > timestampi

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Vladimir Oltean
On Thu, Nov 19, 2020 at 12:09:06PM +0100, Christian Eggers wrote: > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > immediately. Shouldn't store a pointer to freed memory. > > Signed-off-by: Christian Eggers > Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone

[PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-19 Thread Christian Eggers
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed immediately. Shouldn't store a pointer to freed memory. Signed-off-by: Christian Eggers Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX timestamping") --- Changes since v1: - Fixed "Fixes:" tag (and conf