Re: [MPTCP] Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Paolo Abeni
On Wed, 2020-12-02 at 17:51 +0100, Paolo Abeni wrote: > On Wed, 2020-12-02 at 17:45 +0100, Eric Dumazet wrote: > > Packetdrill recvmsg syntax would be something like > > > >+0 recvmsg(3, {msg_name(...)=..., > > msg_iov(1)=[{..., 0}], > > msg_flags=0 > >

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Paolo Abeni
On Wed, 2020-12-02 at 17:45 +0100, Eric Dumazet wrote: > > On 12/2/20 5:32 PM, Eric Dumazet wrote: > > > > On 12/2/20 5:30 PM, Eric Dumazet wrote: > > > > > > On 12/2/20 5:10 PM, Eric Dumazet wrote: > > > > > > > > On 12/2/20 4:37 PM, Paolo Abeni wrote: > > > > > On Wed, 2020-12-02 at 14:18 +01

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 12/2/20 5:32 PM, Eric Dumazet wrote: > > > On 12/2/20 5:30 PM, Eric Dumazet wrote: >> >> >> On 12/2/20 5:10 PM, Eric Dumazet wrote: >>> >>> >>> On 12/2/20 4:37 PM, Paolo Abeni wrote: On Wed, 2020-12-02 at 14:18 +0100, Eric Dumazet wrote: > > On 11/24/20 10:51 PM, Paolo Abeni wr

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 12/2/20 5:30 PM, Eric Dumazet wrote: > > > On 12/2/20 5:10 PM, Eric Dumazet wrote: >> >> >> On 12/2/20 4:37 PM, Paolo Abeni wrote: >>> On Wed, 2020-12-02 at 14:18 +0100, Eric Dumazet wrote: On 11/24/20 10:51 PM, Paolo Abeni wrote: > We can enter the main mptcp_recvmsg() loop e

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 12/2/20 5:10 PM, Eric Dumazet wrote: > > > On 12/2/20 4:37 PM, Paolo Abeni wrote: >> On Wed, 2020-12-02 at 14:18 +0100, Eric Dumazet wrote: >>> >>> On 11/24/20 10:51 PM, Paolo Abeni wrote: We can enter the main mptcp_recvmsg() loop even when no subflows are connected. As note by E

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 12/2/20 4:37 PM, Paolo Abeni wrote: > On Wed, 2020-12-02 at 14:18 +0100, Eric Dumazet wrote: >> >> On 11/24/20 10:51 PM, Paolo Abeni wrote: >>> We can enter the main mptcp_recvmsg() loop even when >>> no subflows are connected. As note by Eric, that would >>> result in a divide by zero oops o

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Paolo Abeni
On Wed, 2020-12-02 at 14:18 +0100, Eric Dumazet wrote: > > On 11/24/20 10:51 PM, Paolo Abeni wrote: > > We can enter the main mptcp_recvmsg() loop even when > > no subflows are connected. As note by Eric, that would > > result in a divide by zero oops on ack generation. > > > > Address the issue

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 11/24/20 10:51 PM, Paolo Abeni wrote: > We can enter the main mptcp_recvmsg() loop even when > no subflows are connected. As note by Eric, that would > result in a divide by zero oops on ack generation. > > Address the issue by checking the subflow status before > sending the ack. > > Addit

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 22:51:24 +0100 Paolo Abeni wrote: > We can enter the main mptcp_recvmsg() loop even when > no subflows are connected. As note by Eric, that would > result in a divide by zero oops on ack generation. > > Address the issue by checking the subflow status before > sending the ack.

[PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-11-24 Thread Paolo Abeni
We can enter the main mptcp_recvmsg() loop even when no subflows are connected. As note by Eric, that would result in a divide by zero oops on ack generation. Address the issue by checking the subflow status before sending the ack. Additionally protect mptcp_recvmsg() against invocation with weir