Re: [PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-05 Thread Marc Angel
On Thu, May 5, 2016 at 4:53 AM, David Miller wrote: > From: Marc Angel > Date: Thu, 5 May 2016 01:33:09 +0100 > >> On Wed, May 4, 2016 at 9:04 PM, David Miller wrote: >>> From: Marc Angel >>> Date: Tue, 3 May 2016 20:30:54 +0200 >>> @@ -1274,6 +1285,7 @@ static int macvtap_device_event(st

Re: [PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-04 Thread David Miller
From: Marc Angel Date: Thu, 5 May 2016 01:33:09 +0100 > On Wed, May 4, 2016 at 9:04 PM, David Miller wrote: >> From: Marc Angel >> Date: Tue, 3 May 2016 20:30:54 +0200 >> >>> @@ -1274,6 +1285,7 @@ static int macvtap_device_event(struct notifier_block >>> *unused, >>>

Re: [PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-04 Thread Marc Angel
On Wed, May 4, 2016 at 9:04 PM, David Miller wrote: > From: Marc Angel > Date: Tue, 3 May 2016 20:30:54 +0200 > >> @@ -1274,6 +1285,7 @@ static int macvtap_device_event(struct notifier_block >> *unused, >> unsigned long event, void *ptr) >> { >> struct net_d

Re: [PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-04 Thread David Miller
From: Marc Angel Date: Tue, 3 May 2016 20:30:54 +0200 > @@ -1274,6 +1285,7 @@ static int macvtap_device_event(struct notifier_block > *unused, > unsigned long event, void *ptr) > { > struct net_device *dev = netdev_notifier_info_to_dev(ptr); > + const ch

[PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-03 Thread Marc Angel
When creating macvtaps that are expected to have the same ifindex in different network namespaces, only the first one will succeed. The others will fail with a sysfs_warn_dup warning due to them trying to create the following sysfs link (with 'NN' the ifindex of macvtapX): /sys/class/macvtap/tapNN