Hi Harald,
Le 27/08/2020 à 11:00, Harald Welte a écrit :
> Hi Nicolas,
>
> On Thu, Aug 27, 2020 at 12:36:24AM +0200, Nicolas Dichtel wrote:
>> Le 26/08/2020 à 20:52, Harald Welte a écrit :
>
>>> Wouldn't it make sense to only allocate + fill those messages if we
>>> actually knew a subscriber ex
Hi Nicolas,
On Thu, Aug 27, 2020 at 12:36:24AM +0200, Nicolas Dichtel wrote:
> Le 26/08/2020 à 20:52, Harald Welte a écrit :
> > Wouldn't it make sense to only allocate + fill those messages if we
> > actually knew a subscriber existed?
>
> In fact, this is actually how the netlink framework work
Le 26/08/2020 à 20:52, Harald Welte a écrit :
> Hi Nicolas,
>
> On Wed, Aug 26, 2020 at 09:47:54AM +0200, Nicolas Dichtel wrote:
>>> Sending (unsolicited) notifications about all of those seems quite
>>> heavyweight to me.
>>
>> There is no 'unsolicited' notifications with this patch. Notificatio
Hi Nicolas,
On Wed, Aug 26, 2020 at 09:47:54AM +0200, Nicolas Dichtel wrote:
> > Sending (unsolicited) notifications about all of those seems quite
> > heavyweight to me.
>
> There is no 'unsolicited' notifications with this patch. Notifications are
> sent
> only if a userspace application has s
Le 25/08/2020 à 19:01, Harald Welte a écrit :
> Hi Nicolas,
>
> thanks a lot for your patch.
>
> On Tue, Aug 25, 2020 at 05:57:15PM +0200, Nicolas Dichtel wrote:
>> Like all other network functions, let's notify gtp context on creation and
>> deletion.
>
> While this may be in-line with typical
Hi Nicolas,
thanks a lot for your patch.
On Tue, Aug 25, 2020 at 05:57:15PM +0200, Nicolas Dichtel wrote:
> Like all other network functions, let's notify gtp context on creation and
> deletion.
While this may be in-line with typical kernel tunnel device practises, I am not
convinced it is the r
Like all other network functions, let's notify gtp context on creation and
deletion.
Signed-off-by: Nicolas Dichtel
Tested-by: Gabriel Ganne
---
v1 -> v2:
- fix typo in the commit title
- fix indentation of GTP_GENL_MCGRP
drivers/net/gtp.c| 58 +--
