Re: [PATCH net-next v2] can: initial support for network namespaces

2017-04-10 Thread Oliver Hartkopp
Hello Mario, On 04/10/2017 09:51 AM, Mario Kicherer wrote: You didn't include the statistics here: + struct s_stats *can_stats; /* packet statistics */ + struct s_pstats *can_pstats;/* receive list statistics */ which need to be per-net too, right? I was not sure how th

Re: [PATCH net-next v2] can: initial support for network namespaces

2017-04-10 Thread Mario Kicherer
Hello Oliver, You didn't include the statistics here: + struct s_stats *can_stats; /* packet statistics */ + struct s_pstats *can_pstats;/* receive list statistics */ which need to be per-net too, right? I was not sure how this information is used - e.g., maybe just as d

Re: [PATCH net-next v2] can: initial support for network namespaces

2017-04-08 Thread Oliver Hartkopp
Hi Mario, I started to convert the statistics ... but there's some code adaption missing in proc.c Is this the right way to start? diff --git a/include/net/netns/can.h b/include/net/netns/can.h index e8beba772f1a..a8866ae1788f 100644 --- a/include/net/netns/can.h +++ b/include/net/netns/can.h

Re: [PATCH net-next v2] can: initial support for network namespaces

2017-04-08 Thread Oliver Hartkopp
Hello Mario, unfortunately Marc pushed this patch before I finally was able to review it ... :-( Some questions: On 02/21/2017 12:19 PM, Mario Kicherer wrote: This patch adds initial support for network namespaces. The changes only enable support in the CAN raw, proc and af_can code. GW and

[PATCH net-next v2] can: initial support for network namespaces

2017-02-21 Thread Mario Kicherer
This patch adds initial support for network namespaces. The changes only enable support in the CAN raw, proc and af_can code. GW and BCM still have their checks that ensure that they are used only from the main namespace. The patch boils down to moving the global structures, i.e. the global filter