On Thu, Aug 20, 2020 at 05:14:31PM -0700, Jakub Kicinski wrote:
> On Fri, 21 Aug 2020 02:04:39 +0300 Vladimir Oltean wrote:
> > On Thu, Jul 30, 2020 at 05:30:59PM -0700, Jakub Kicinski wrote:
> > > On Thu, 30 Jul 2020 18:53:58 -0400 David Thompson wrote:
> > > > +
> > > > + /* Tell networki
On Fri, 21 Aug 2020 02:04:39 +0300 Vladimir Oltean wrote:
> On Thu, Jul 30, 2020 at 05:30:59PM -0700, Jakub Kicinski wrote:
> > On Thu, 30 Jul 2020 18:53:58 -0400 David Thompson wrote:
> > > +
> > > + /* Tell networking subsystem to poll GigE driver */
> > > + napi_schedule(&priv->napi);
> >
>
On Thu, Jul 30, 2020 at 05:30:59PM -0700, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 18:53:58 -0400 David Thompson wrote:
> > +
> > + /* Tell networking subsystem to poll GigE driver */
> > + napi_schedule(&priv->napi);
>
> _irqoff
Hmm, I wouldn't be so sure about this particular advice. Wit
From: David Thompson
Date: Thu, 20 Aug 2020 18:51:39 +
> When I wrote the Kconfig definition I was thinking that "INET" is an
> obvious functional dependency for an Ethernet driver.
People can and should be able to use your driver even if ipv4/ipv6 is
disabled, don't you think?
> Yes, the m
On Thu, 20 Aug 2020 18:51:39 + David Thompson wrote:
> > > + for (i = 0; i < priv->rx_q_entries; i++) {
> > > + /* Allocate a receive buffer for this RX WQE. The DMA
> > > + * form (dma_addr_t) of the receive buffer address is
> > > + * stored in the RX WQE array (via
> > +config MLXBF_GIGE
> > + tristate "Mellanox Technologies BlueField Gigabit Ethernet support"
> > + depends on (ARM64 || COMPILE_TEST) && ACPI && INET
>
> Why do you depend on INET? :S
>
When I wrote the Kconfig definition I was thinking that "INET" is an
obvious functional dependency for
On Thu, 30 Jul 2020 18:53:58 -0400 David Thompson wrote:
> The logic in "mlxbf_gige_mdio.c" is the driver controlling
> the Mellanox BlueField hardware that interacts with a PHY
> device via MDIO/MDC pins. This driver does the following:
> - At driver probe time, it configures several BlueField
This patch adds build and driver logic for the "mlxbf_gige"
Ethernet driver from Mellanox Technologies. The second
generation BlueField SoC from Mellanox supports an
out-of-band GigaBit Ethernet management port to the Arm
subsystem. This driver supports TCP/IP network connectivity
for that port, a
