Re: [PATCH net-next v1 1/8] netfilter: inlined four headers files into another one.

On 2019-08-08, at 13:23:55 +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 07, 2019 at 03:16:58PM +0100, Jeremy Sowden wrote: > [...] > > +/* Called from uadd only, protected by the set spinlock. > > + * The kadt functions don't use the comment extensions in any way. > > + */ > > +static inline void

Re: [PATCH net-next v1 1/8] netfilter: inlined four headers files into another one.

Hi Jeremy, On Wed, 7 Aug 2019, Jeremy Sowden wrote: > linux/netfilter/ipset/ip_set.h included four other header files: > > include/linux/netfilter/ipset/ip_set_comment.h > include/linux/netfilter/ipset/ip_set_counter.h > include/linux/netfilter/ipset/ip_set_skbinfo.h > include/linux/netf

Re: [PATCH net-next v1 1/8] netfilter: inlined four headers files into another one.

Hi Jeremy, Thanks for working on this. Cc'ing Jozsef. On Wed, Aug 07, 2019 at 03:16:58PM +0100, Jeremy Sowden wrote: [...] > +/* Called from uadd only, protected by the set spinlock. > + * The kadt functions don't use the comment extensions in any way. > + */ > +static inline void > +ip_set_init

[PATCH net-next v1 1/8] netfilter: inlined four headers files into another one.

linux/netfilter/ipset/ip_set.h included four other header files: include/linux/netfilter/ipset/ip_set_comment.h include/linux/netfilter/ipset/ip_set_counter.h include/linux/netfilter/ipset/ip_set_skbinfo.h include/linux/netfilter/ipset/ip_set_timeout.h Of these the first three were not in