Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

2017-08-18 Thread Tom Lendacky
On 8/18/2017 12:02 AM, David Miller wrote: From: Andrew Lunn Date: Fri, 18 Aug 2017 02:30:57 +0200 On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote: Add additional debugfs support for reading / writing registers of any attached external phy devices as well as the SFP eeprom data.

Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

2017-08-17 Thread David Miller
From: Andrew Lunn Date: Fri, 18 Aug 2017 02:30:57 +0200 > On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote: >> Add additional debugfs support for reading / writing registers of any >> attached external phy devices as well as the SFP eeprom data. > > Hi Tom > > What is wrong with usi

Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

2017-08-17 Thread Andrew Lunn
On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote: > Add additional debugfs support for reading / writing registers of any > attached external phy devices as well as the SFP eeprom data. Hi Tom What is wrong with using the standard APIs for this? ethtool --moduile-info ioctls SIOCGMI

[PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

2017-08-17 Thread Tom Lendacky
Add additional debugfs support for reading / writing registers of any attached external phy devices as well as the SFP eeprom data. These debugfs files will only be created if the phy implementation supports them. Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 1