Re: [PATCH net-next v1] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Jonathan Maxwell
On Thu, May 10, 2018 at 3:45 PM, Eric Dumazet wrote: > > > On 05/09/2018 10:21 PM, Jon Maxwell wrote: > > ... > >> if (th->rst) >> @@ -723,11 +724,17 @@ static void tcp_v4_send_reset(const struct sock *sk, >> struct sk_buff *skb) >> arg.tos = ip_hdr(skb)->tos; >> arg.uid = sock_

Re: [PATCH net-next v1] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Eric Dumazet
On 05/09/2018 10:21 PM, Jon Maxwell wrote: ... > if (th->rst) > @@ -723,11 +724,17 @@ static void tcp_v4_send_reset(const struct sock *sk, > struct sk_buff *skb) > arg.tos = ip_hdr(skb)->tos; > arg.uid = sock_net_uid(net, sk && sk_fullsock(sk) ? sk : NULL); > local_bh_d

[PATCH net-next v1] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Jon Maxwell
This version has some suggestions by Eric Dumazet: - Use a local variable for the mark in IPv6 instead of ctl_sk to avoid SMP races. - Use the more elegant "IP4_REPLY_MARK(net, skb->mark) ?: sk->sk_mark" statement. Aidan McGurn from Openwave Mobility systems reported the following bug: "Marke