Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-08 Thread Eli Britstein
On 2/8/2019 9:59 AM, Simon Horman wrote: > On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: >> From: Gregory Rose >> Date: Mon, 4 Feb 2019 11:41:29 -0800 >> >>> On 2/3/2019 1:12 AM, Eli Britstein wrote: Declare ovs key structures using macros as a pre-step towards to enable

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-07 Thread Simon Horman
On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: > From: Gregory Rose > Date: Mon, 4 Feb 2019 11:41:29 -0800 > > > > > On 2/3/2019 1:12 AM, Eli Britstein wrote: > >> Declare ovs key structures using macros as a pre-step towards to > >> enable retrieving fields information, as a work

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-06 Thread Eli Britstein
On 2/5/2019 10:23 PM, Ben Pfaff wrote: > On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote: >> On 2/5/2019 4:02 AM, Eli Britstein wrote: >>> On 2/4/2019 10:07 PM, David Miller wrote: From: Yi-Hung Wei Date: Mon, 4 Feb 2019 10:47:18 -0800 > For example, to see how 'st

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-05 Thread Ben Pfaff
On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote: > > On 2/5/2019 4:02 AM, Eli Britstein wrote: > > On 2/4/2019 10:07 PM, David Miller wrote: > > > From: Yi-Hung Wei > > > Date: Mon, 4 Feb 2019 10:47:18 -0800 > > > > > > > For example, to see how 'struct ovs_key_ipv6' is defined, now

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-05 Thread Gregory Rose
On 2/5/2019 4:02 AM, Eli Britstein wrote: On 2/4/2019 10:07 PM, David Miller wrote: From: Yi-Hung Wei Date: Mon, 4 Feb 2019 10:47:18 -0800 For example, to see how 'struct ovs_key_ipv6' is defined, now we need to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR and OVS_KEY

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-05 Thread Eli Britstein
On 2/4/2019 10:07 PM, David Miller wrote: > From: Yi-Hung Wei > Date: Mon, 4 Feb 2019 10:47:18 -0800 > >> For example, to see how 'struct ovs_key_ipv6' is defined, now we need >> to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR >> and OVS_KEY_FIELD defined. I think it makes

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread David Miller
From: Gregory Rose Date: Mon, 4 Feb 2019 11:41:29 -0800 > > On 2/3/2019 1:12 AM, Eli Britstein wrote: >> Declare ovs key structures using macros as a pre-step towards to >> enable retrieving fields information, as a work done in proposed >> commit in the OVS tree https://patchwork.ozlabs.org/pat

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread David Miller
From: Yi-Hung Wei Date: Mon, 4 Feb 2019 10:47:18 -0800 > For example, to see how 'struct ovs_key_ipv6' is defined, now we need > to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR > and OVS_KEY_FIELD defined. I think it makes the header file to be > more complicated. I compl

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread Gregory Rose
On 2/3/2019 1:12 AM, Eli Britstein wrote: Declare ovs key structures using macros as a pre-step towards to enable retrieving fields information, as a work done in proposed commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ ("odp-util: Do not rewrite fields with the same values a

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-04 Thread Yi-Hung Wei
On Sun, Feb 3, 2019 at 1:13 AM Eli Britstein wrote: > > Declare ovs key structures using macros as a pre-step towards to > enable retrieving fields information, as a work done in proposed > commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ > ("odp-util: Do not rewrite fields with

Re: [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-03 Thread Pravin Shelar
On Sun, Feb 3, 2019 at 1:12 AM Eli Britstein wrote: > > Declare ovs key structures using macros as a pre-step towards to > enable retrieving fields information, as a work done in proposed > commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ > ("odp-util: Do not rewrite fields with

[PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-03 Thread Eli Britstein
Declare ovs key structures using macros as a pre-step towards to enable retrieving fields information, as a work done in proposed commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ ("odp-util: Do not rewrite fields with the same values as matched"), with no functional change. Signe