Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-20 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 8:39 PM, Mel Gorman wrote: > On Tue, Apr 19, 2016 at 06:25:32PM +0200, Jesper Dangaard Brouer wrote: >> On Mon, 18 Apr 2016 07:17:13 -0700 >> Eric Dumazet wrote: >> > > alloc_pages_exact() > We want to allocate 32 order-0 physically contiguous pages and to free each one o

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-19 Thread Saeed Mahameed
On Tue, Apr 19, 2016 at 7:25 PM, Jesper Dangaard Brouer wrote: > On Mon, 18 Apr 2016 07:17:13 -0700 > Eric Dumazet wrote: > >> Another idea would be to have a way to control max number of order-5 >> pages that a port would be using. >> >> Since driver always own a ref on a order-5 pages, idea wou

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-19 Thread Mel Gorman
On Tue, Apr 19, 2016 at 06:25:32PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 18 Apr 2016 07:17:13 -0700 > Eric Dumazet wrote: > > > On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > > > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet > > > wrote: > > > > On Sun, 2016-04-17 at 17:2

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-19 Thread Jesper Dangaard Brouer
On Mon, 18 Apr 2016 07:17:13 -0700 Eric Dumazet wrote: > On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet > > wrote: > > > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > > > > >> > > >> If really you need to allocate phys

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-18 Thread Eric Dumazet
On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet wrote: > > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > > >> > >> If really you need to allocate physically contiguous memory, have you > >> considered converting the order-5 page

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-18 Thread Saeed Mahameed
On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet wrote: > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > >> >> If really you need to allocate physically contiguous memory, have you >> considered converting the order-5 pages into 32 order-0 ones ? > > Search for split_page() call sites for e

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-18 Thread Eric Dumazet
On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > If really you need to allocate physically contiguous memory, have you > considered converting the order-5 pages into 32 order-0 ones ? Search for split_page() call sites for examples.

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-17 Thread Eric Dumazet
On Mon, 2016-04-18 at 00:31 +0300, Saeed Mahameed wrote: > Performance tested on ConnectX4-Lx 50G. > To isolate the feature under test, the numbers below were measured with > HW LRO turned off. We verified that the performance just improves when > LRO is turned back on. > > * Netperf single TCP s

[PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-04-17 Thread Saeed Mahameed
From: Tariq Toukan Introduce the feature of multi-packet WQE (RX Work Queue Element) referred to as (MPWQE or Striding RQ), in which WQEs are larger and serve multiple packets each. Every WQE consists of many strides of the same size, every received packet is aligned to a beginning of a stride a