Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-08 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 8 Dec 2017 06:43:44 +0200 > On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote: >> Private destructor could be called when register_netdev() fail with >> rtnl lock held. This will lead deadlock in tun_free_netdev() who tries >> to hold rtnl_lock. Fixi

Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Eric Dumazet
On Fri, 2017-12-08 at 12:02 +0800, Jason Wang wrote: > Private destructor could be called when register_netdev() fail with > rtnl lock held. This will lead deadlock in tun_free_netdev() who > tries > to hold rtnl_lock. Fixing this by switching to use spinlock to > synchronize. > > Fixes: 96f840616

Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Michael S. Tsirkin
On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote: > Private destructor could be called when register_netdev() fail with > rtnl lock held. This will lead deadlock in tun_free_netdev() who tries > to hold rtnl_lock. Fixing this by switching to use spinlock to > synchronize. > > Fixes: 96f8

[PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock to synchronize. Fixes: 96f84061620c ("tun: add eBPF based queue selection method") Reported-by: Eri