Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-17 Thread Arnd Bergmann
On Sat, Jan 16, 2021 at 10:41 PM Heiner Kallweit wrote: > >> > >> It seems unlikely that a system uses both, the parallel *and* the SPI > >> variant of the ks8851. So the additional memory necessary because of > >> code duplication wouldn't matter in practice. > > > > I have a board with both opt

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Heiner Kallweit
On 16.01.2021 22:25, Marek Vasut wrote: > On 1/16/21 9:39 PM, Lukas Wunner wrote: >> On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: >>> On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: On 1/16/21 6:04 PM, Arnd Bergmann wrote: > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/16/21 9:39 PM, Lukas Wunner wrote: On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: On 1/16/21 6:04 PM, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: I don't really like this version, as it doe

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Lukas Wunner
On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: > On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: > > On 1/16/21 6:04 PM, Arnd Bergmann wrote: > > > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > > > > I don't really like this version, as it does not actually solve the

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Arnd Bergmann
On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: > On 1/16/21 6:04 PM, Arnd Bergmann wrote: > > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > > I don't really like this version, as it does not actually solve the problem > > of > > linking the same object file into both vmlinux and a l

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/16/21 6:04 PM, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Arnd Bergmann
On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > When either the SPI or PAR variant is compiled as module AND the other > variant is compiled as built-in, the following build error occurs: > > arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in > function `ks8851_probe_com

[PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': ks8851_common.c:(.text+0x1564): undefined reference to `_