On Fri, Nov 04, 2016 at 04:05:51PM -0700, John Fastabend wrote:
> On 16-11-03 05:34 PM, Michael S. Tsirkin wrote:
> > On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote:
> >> [...]
> >>
> > - when XDP is attached disable all LRO using
> > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET
> >>
On 16-11-03 05:34 PM, Michael S. Tsirkin wrote:
> On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote:
>> [...]
>>
> - when XDP is attached disable all LRO using
> VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET
> (not used by driver so far, designed to allow dynamic LRO control with
>
On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote:
> [...]
>
> >>> - when XDP is attached disable all LRO using
> >>> VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET
> >>> (not used by driver so far, designed to allow dynamic LRO control with
> >>>ethtool)
> >>
> >> I see there is a UAPI bi
[...]
>>> - when XDP is attached disable all LRO using
>>> VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET
>>> (not used by driver so far, designed to allow dynamic LRO control with
>>>ethtool)
>>
>> I see there is a UAPI bit for this but I guess we also need to add
>> support to vhost as well? Seems ot
com; m...@redhat.com;
> >>> shrij...@gmail.com; t...@herbertland.com; netdev@vger.kernel.org;
> >>> Roopa Prabhu ; Nikolay Aleksandrov
> >>> ; bro...@redhat.com
> >>> Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for
> >> vi
gt;>> shrij...@gmail.com; t...@herbertland.com; netdev@vger.kernel.org;
>>>> Roopa Prabhu ; Nikolay Aleksandrov
>>>> ; bro...@redhat.com
>>>> Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for
>>> virtio_net
>>>>
>>>
; Roopa Prabhu ; Nikolay Aleksandrov
>>> ; bro...@redhat.com
>>> Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for
>> virtio_net
>>>
>>> On Sat, 29 Oct 2016 13:25:14 +0200
>>> Thomas Graf wrote:
>>>
>>>> On 10/28/1
arovoitov
> > ; Jakub Kicinski ; John
> > Fastabend ; David Miller
> > ; alexander.du...@gmail.com; m...@redhat.com;
> > shrij...@gmail.com; t...@herbertland.com; netdev@vger.kernel.org;
> > Roopa Prabhu ; Nikolay Aleksandrov
> > ; bro...@redhat.com
> > Subj
ail.com; m...@redhat.com;
> shrij...@gmail.com; t...@herbertland.com; netdev@vger.kernel.org;
> Roopa Prabhu ; Nikolay Aleksandrov
> ; bro...@redhat.com
> Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for
virtio_net
>
> On Sat, 29 Oct 2016 13:25:14 +0200
> Tho
On Wed, Nov 2, 2016 at 7:01 AM, Jesper Dangaard Brouer
wrote:
> On Fri, 28 Oct 2016 13:11:01 -0400 (EDT)
> David Miller wrote:
>
>> From: John Fastabend
>> Date: Fri, 28 Oct 2016 08:56:35 -0700
>>
>> > On 16-10-27 07:10 PM, David Miller wrote:
>> >> From: Alexander Duyck
>> >> Date: Thu, 27 Oct
On Sat, 29 Oct 2016 13:25:14 +0200
Thomas Graf wrote:
> On 10/28/16 at 08:51pm, Shrijeet Mukherjee wrote:
> > Generally agree, but SRIOV nics with multiple queues can end up in a bad
> > spot if each buffer was 4K right ? I see a specific page pool to be used
> > by queues which are enabled for X
On Fri, 28 Oct 2016 13:11:01 -0400 (EDT)
David Miller wrote:
> From: John Fastabend
> Date: Fri, 28 Oct 2016 08:56:35 -0700
>
> > On 16-10-27 07:10 PM, David Miller wrote:
> >> From: Alexander Duyck
> >> Date: Thu, 27 Oct 2016 18:43:59 -0700
> >>
> >>> On Thu, Oct 27, 2016 at 6:35 PM, Dav
On Fri, Oct 28, 2016 at 01:11:01PM -0400, David Miller wrote:
> From: John Fastabend
> Date: Fri, 28 Oct 2016 08:56:35 -0700
>
> > On 16-10-27 07:10 PM, David Miller wrote:
> >> From: Alexander Duyck
> >> Date: Thu, 27 Oct 2016 18:43:59 -0700
> >>
> >>> On Thu, Oct 27, 2016 at 6:35 PM, David Mi
On 10/28/16 at 08:51pm, Shrijeet Mukherjee wrote:
> Generally agree, but SRIOV nics with multiple queues can end up in a bad
> spot if each buffer was 4K right ? I see a specific page pool to be used
> by queues which are enabled for XDP as the easiest to swing solution that
> way the memory overhe
shrij...@gmail.com; t...@herbertland.com;
> netdev@vger.kernel.org; s...@cumulusnetworks.com;
> ro...@cumulusnetworks.com; niko...@cumulusnetworks.com
> Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for
virtio_net
>
> On Fri, Oct 28, 2016 at 05:18:12PM +0100, Jakub Kicinski wrote:
&g
On Fri, 28 Oct 2016 13:35:02 -0700, Alexander Duyck wrote:
> > At the same time XDP doesn't require to use 4k buffer in something like
> > Netronome.
> > If xdp bpf program can be offloaded into HW with 1800 byte buffers, great!
>
> So are you saying this is only really meant to be used with a
On Fri, 28 Oct 2016 11:22:25 -0700, Alexei Starovoitov wrote:
> On Fri, Oct 28, 2016 at 05:18:12PM +0100, Jakub Kicinski wrote:
> > On Fri, 28 Oct 2016 08:56:35 -0700, John Fastabend wrote:
> > > On 16-10-27 07:10 PM, David Miller wrote:
> > > > From: Alexander Duyck
> > > > Date: Thu, 27 Oct
On Fri, Oct 28, 2016 at 11:22 AM, Alexei Starovoitov
wrote:
> On Fri, Oct 28, 2016 at 05:18:12PM +0100, Jakub Kicinski wrote:
>> On Fri, 28 Oct 2016 08:56:35 -0700, John Fastabend wrote:
>> > On 16-10-27 07:10 PM, David Miller wrote:
>> > > From: Alexander Duyck
>> > > Date: Thu, 27 Oct 2016 18:4
On Fri, Oct 28, 2016 at 05:18:12PM +0100, Jakub Kicinski wrote:
> On Fri, 28 Oct 2016 08:56:35 -0700, John Fastabend wrote:
> > On 16-10-27 07:10 PM, David Miller wrote:
> > > From: Alexander Duyck
> > > Date: Thu, 27 Oct 2016 18:43:59 -0700
> > >
> > >> On Thu, Oct 27, 2016 at 6:35 PM, David M
From: John Fastabend
Date: Fri, 28 Oct 2016 08:56:35 -0700
> On 16-10-27 07:10 PM, David Miller wrote:
>> From: Alexander Duyck
>> Date: Thu, 27 Oct 2016 18:43:59 -0700
>>
>>> On Thu, Oct 27, 2016 at 6:35 PM, David Miller wrote:
From: "Michael S. Tsirkin"
Date: Fri, 28 Oct 2016 01:2
On Fri, 28 Oct 2016 08:56:35 -0700, John Fastabend wrote:
> On 16-10-27 07:10 PM, David Miller wrote:
> > From: Alexander Duyck
> > Date: Thu, 27 Oct 2016 18:43:59 -0700
> >
> >> On Thu, Oct 27, 2016 at 6:35 PM, David Miller wrote:
> >>
> >>> From: "Michael S. Tsirkin"
> >>> Date: Fri, 28
On 16-10-27 07:10 PM, David Miller wrote:
> From: Alexander Duyck
> Date: Thu, 27 Oct 2016 18:43:59 -0700
>
>> On Thu, Oct 27, 2016 at 6:35 PM, David Miller wrote:
>>> From: "Michael S. Tsirkin"
>>> Date: Fri, 28 Oct 2016 01:25:48 +0300
>>>
On Thu, Oct 27, 2016 at 05:42:18PM -0400, David M
From: Alexander Duyck
Date: Thu, 27 Oct 2016 18:43:59 -0700
> On Thu, Oct 27, 2016 at 6:35 PM, David Miller wrote:
>> From: "Michael S. Tsirkin"
>> Date: Fri, 28 Oct 2016 01:25:48 +0300
>>
>>> On Thu, Oct 27, 2016 at 05:42:18PM -0400, David Miller wrote:
From: "Michael S. Tsirkin"
Da
On Thu, Oct 27, 2016 at 6:35 PM, David Miller wrote:
> From: "Michael S. Tsirkin"
> Date: Fri, 28 Oct 2016 01:25:48 +0300
>
>> On Thu, Oct 27, 2016 at 05:42:18PM -0400, David Miller wrote:
>>> From: "Michael S. Tsirkin"
>>> Date: Fri, 28 Oct 2016 00:30:35 +0300
>>>
>>> > Something I'd like to un
From: "Michael S. Tsirkin"
Date: Fri, 28 Oct 2016 01:25:48 +0300
> On Thu, Oct 27, 2016 at 05:42:18PM -0400, David Miller wrote:
>> From: "Michael S. Tsirkin"
>> Date: Fri, 28 Oct 2016 00:30:35 +0300
>>
>> > Something I'd like to understand is how does XDP address the
>> > problem that 100Byte
ger.kernel.org; Roopa Prabhu ;
> Nikolay Aleksandrov
> Subject: RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net
>
> > >
> > > Looking at the virtio_net.c code, the function call receive_big()
> > >might actually be okay for XDP, unless the incoming p
> >
> > Looking at the virtio_net.c code, the function call receive_big()
> > might actually be okay for XDP, unless the incoming packet is larger
> > than PAGE_SIZE and thus uses several pages (via a linked list in page-
> >private).
> >
> > The receive_mergeable() does not look compatible with XD
On Thu, Oct 27, 2016 at 05:42:18PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin"
> Date: Fri, 28 Oct 2016 00:30:35 +0300
>
> > Something I'd like to understand is how does XDP address the
> > problem that 100Byte packets are consuming 4K of memory now.
>
> Via page pools. We're going
From: "Michael S. Tsirkin"
Date: Fri, 28 Oct 2016 00:30:35 +0300
> Something I'd like to understand is how does XDP address the
> problem that 100Byte packets are consuming 4K of memory now.
Via page pools. We're going to make a generic one, but right now
each and every driver implements a quic
On Thu, Oct 27, 2016 at 02:09:08PM -0700, John Fastabend wrote:
> On 16-10-27 01:55 AM, Jesper Dangaard Brouer wrote:
> > On Wed, 26 Oct 2016 13:11:22 -0400 (EDT)
> > David Miller wrote:
> >
> >> From: "Michael S. Tsirkin"
> >> Date: Wed, 26 Oct 2016 20:07:19 +0300
> >>
> >>> On Wed, Oct 26, 201
On 16-10-27 01:55 AM, Jesper Dangaard Brouer wrote:
> On Wed, 26 Oct 2016 13:11:22 -0400 (EDT)
> David Miller wrote:
>
>> From: "Michael S. Tsirkin"
>> Date: Wed, 26 Oct 2016 20:07:19 +0300
>>
>>> On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote:
From: "Michael S. Tsirkin"
>>
On Wed, 26 Oct 2016 13:11:22 -0400 (EDT)
David Miller wrote:
> From: "Michael S. Tsirkin"
> Date: Wed, 26 Oct 2016 20:07:19 +0300
>
> > On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote:
> >> From: "Michael S. Tsirkin"
> >> Date: Wed, 26 Oct 2016 19:36:45 +0300
> >>
> >> > On W
From: "Michael S. Tsirkin"
Date: Wed, 26 Oct 2016 20:07:19 +0300
> On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote:
>> From: "Michael S. Tsirkin"
>> Date: Wed, 26 Oct 2016 19:36:45 +0300
>>
>> > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote:
>> >> On Sat, 2
On Wed, Oct 26, 2016 at 12:52:45PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin"
> Date: Wed, 26 Oct 2016 19:36:45 +0300
>
> > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote:
> >> On Sat, 22 Oct 2016 04:07:23 +
> >> Shrijeet Mukherjee wrote:
> >>
> >> > Thi
From: "Michael S. Tsirkin"
Date: Wed, 26 Oct 2016 19:36:45 +0300
> On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote:
>> On Sat, 22 Oct 2016 04:07:23 +
>> Shrijeet Mukherjee wrote:
>>
>> > This patch adds support for xdp ndo and also inserts the xdp program
>> > call in
On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote:
> On Sat, 22 Oct 2016 04:07:23 +
> Shrijeet Mukherjee wrote:
>
> > This patch adds support for xdp ndo and also inserts the xdp program
> > call into the merged RX buffers and big buffers paths
>
> I really appreciate yo
On Sat, 22 Oct 2016 04:07:23 +
Shrijeet Mukherjee wrote:
> This patch adds support for xdp ndo and also inserts the xdp program
> call into the merged RX buffers and big buffers paths
I really appreciate you are doing this for virtio_net.
My first question is: Is the (packet) page data writ
On Sat, 22 Oct 2016 04:07:23 +, Shrijeet Mukherjee wrote:
> + act = bpf_prog_run_xdp(xdp_prog, &xdp);
> + switch (act) {
> + case XDP_PASS:
> + return XDP_PASS;
> + case XDP_TX:
> + case XDP_ABORTED:
> +
On Sun, Oct 23, 2016 at 06:51:53PM -0700, Shrijeet Mukherjee wrote:
>
> The main goal of this patch was to start that discussion. My v2 patch
> rejects the ndo op if neither of rx_mergeable or big_buffers are set.
> Does that sound like a good tradeoff ? Don't know enough about who
> turns these f
On Sun, Oct 23, 2016 at 9:38 AM, Stephen Hemminger
wrote:
> Overall, I am glad to see XDP support more widely available. Minor stuff
> in implementation.
>
>>
>> +/* this function is not called from the receive_buf path directly as
>> + * we want to use the page model for rx merge buffer and big b
Overall, I am glad to see XDP support more widely available. Minor stuff
in implementation.
>
> +/* this function is not called from the receive_buf path directly as
> + * we want to use the page model for rx merge buffer and big buffers
> + * and not use the fast path for driving skb's around
>
This patch adds support for xdp ndo and also inserts the xdp program
call into the merged RX buffers and big buffers paths
* The small packet skb receive is skipped for now
* No TX for now
Signed-off-by: Shrijeet Mukherjee
---
drivers/net/virtio_net.c | 133 +
42 matches
Mail list logo
