Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-18 Thread Steffen Klassert
On Mon, Sep 17, 2018 at 10:19:22AM -0400, Willem de Bruijn wrote: > On Mon, Sep 17, 2018 at 6:37 AM Steffen Klassert > wrote: > > > > Maybe in case that forwarding is enabled on the receiving device, > > inet_gro_receive() could do a route lookup and allow GRO if the > > route lookup returned at f

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Willem de Bruijn
On Mon, Sep 17, 2018 at 6:37 AM Steffen Klassert wrote: > > On Fri, Sep 14, 2018 at 01:59:40PM -0400, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > > gro callback configured. > > It would be nice if we could do GRO

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Willem de Bruijn
On Mon, Sep 17, 2018 at 6:24 AM Paolo Abeni wrote: > > On Fri, 2018-09-14 at 13:59 -0400, Willem de Bruijn wrote: > > diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c > > index 4f6aa95a9b12..f44fe328aa0f 100644 > > --- a/net/ipv4/udp_offload.c > > +++ b/net/ipv4/udp_offload.c > > @@ -4

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Willem de Bruijn
On Mon, Sep 17, 2018 at 5:03 AM Steffen Klassert wrote: > > On Fri, Sep 14, 2018 at 01:59:40PM -0400, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > > gro callback configured. > > > > Signed-off-by: Willem de Bruijn

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Steffen Klassert
On Fri, Sep 14, 2018 at 01:59:40PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > gro callback configured. It would be nice if we could do GRO not just for GRO configured sockets, but also for flows that are going

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Paolo Abeni
On Fri, 2018-09-14 at 13:59 -0400, Willem de Bruijn wrote: > diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c > index 4f6aa95a9b12..f44fe328aa0f 100644 > --- a/net/ipv4/udp_offload.c > +++ b/net/ipv4/udp_offload.c > @@ -405,7 +405,7 @@ static struct sk_buff *udp4_gro_receive(struct list

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-17 Thread Steffen Klassert
On Fri, Sep 14, 2018 at 01:59:40PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > gro callback configured. > > Signed-off-by: Willem de Bruijn ... > diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c >

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-16 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 11:37 PM Subash Abhinov Kasiviswanathan wrote: > > On 2018-09-14 11:59, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > > gro callback configured. > > > > Signed-off-by: Willem de Bruijn > > d

Re: [PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-14 Thread Subash Abhinov Kasiviswanathan
On 2018-09-14 11:59, Willem de Bruijn wrote: From: Willem de Bruijn Avoid the socket lookup cost in udp_gro_receive if no socket has a gro callback configured. Signed-off-by: Willem de Bruijn diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index 4f6aa95a9b12..f44fe328aa0f 100644

[PATCH net-next RFC 7/8] udp: gro behind static key

2018-09-14 Thread Willem de Bruijn
From: Willem de Bruijn Avoid the socket lookup cost in udp_gro_receive if no socket has a gro callback configured. Signed-off-by: Willem de Bruijn --- include/net/udp.h | 2 ++ net/ipv4/udp.c | 2 +- net/ipv4/udp_offload.c | 2 +- net/ipv6/udp.c | 2 +- net/ipv6/udp_offloa