Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-10-10 Thread Vivien Didelot
Hi Brandon, Vivien Didelot writes: > Brandon Streiff writes: > >> +.port_ptp_read = mv88e6352_port_ptp_read, >> +.port_ptp_write = mv88e6352_port_ptp_write, >> +.ptp_read = mv88e6352_ptp_read, >> +.ptp_write = mv88e6352_ptp_write, >> +

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:33AM -0500, Brandon Streiff wrote: > This patch implements support for accessing PTP/TAI registers through To avoid confusion, it would be helpful to mention what TAI stands for here and also in the source code comments! Thanks, Richard

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Vivien Didelot
Hi Brandon, Brandon Streiff writes: > + .port_ptp_read = mv88e6352_port_ptp_read, > + .port_ptp_write = mv88e6352_port_ptp_write, > + .ptp_read = mv88e6352_ptp_read, > + .ptp_write = mv88e6352_ptp_write, > + .tai_read

[PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Brandon Streiff
This patch implements support for accessing PTP/TAI registers through the AVB register interface in the Global 2 register. The register interface differs slightly between different models; older models use a 3-bit operations field, while newer models use a 2-bit field. The operations values and th