Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-14 Thread Jakub Kicinski
On Wed, 14 Apr 2021 23:59:22 + Joseph, Jithu wrote: > On Wed, 2021-04-14 at 16:25 -0700, Jakub Kicinski wrote: > > On Wed, 14 Apr 2021 23:14:04 + Joseph, Jithu wrote: > > > If h/w time-stamp is added by the NIC, then metasize will be non > > > zero > > > (as xdp->data is advanced by the

Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-14 Thread Joseph, Jithu
On Wed, 2021-04-14 at 16:25 -0700, Jakub Kicinski wrote: > On Wed, 14 Apr 2021 23:14:04 + Joseph, Jithu wrote: > > > > +static struct sk_buff *igc_construct_skb_zc(struct igc_ring > > > > *ring, > > > > + struct xdp_buff > > > > *xdp) > > > > +{ > > > >

Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-14 Thread Jakub Kicinski
On Wed, 14 Apr 2021 23:14:04 + Joseph, Jithu wrote: > > > +static struct sk_buff *igc_construct_skb_zc(struct igc_ring *ring, > > > + struct xdp_buff *xdp) > > > +{ > > > + unsigned int metasize = xdp->data - xdp->data_meta; > > > + unsigned int datasize = xd

Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-14 Thread Joseph, Jithu
Hi Jakub, Apologies for the delay, I am looking into this as the original developer Andre is no-longer with Intel. I really appreciate your review feedback. (I removed Andre's and Vedang's email from the cc list as they are bouncing and have added a couple of Intel folks) Pardon me if I have

Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 09:43:50 -0700 Tony Nguyen wrote: > From: Andre Guedes > > Add support for receiving packets via AF_XDP zero-copy mechanism. > > Add a new flag to 'enum igc_ring_flags_t' to indicate the ring has > AF_XDP zero-copy enabled so proper ring setup is carried out during ring > con

[PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-09 Thread Tony Nguyen
From: Andre Guedes Add support for receiving packets via AF_XDP zero-copy mechanism. Add a new flag to 'enum igc_ring_flags_t' to indicate the ring has AF_XDP zero-copy enabled so proper ring setup is carried out during ring configuration in igc_configure_rx_ring(). RX buffers can now be alloca