Re: [PATCH net-next 8/9] bnxt_en: Refactor bnxt_dl_info_get().

2020-10-11 Thread Michael Chan
On Sun, Oct 11, 2020 at 2:59 PM Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 06:23:00 -0400 Michael Chan wrote: > > +static int bnxt_dl_info_put(struct bnxt *bp, struct devlink_info_req *req, > > + enum bnxt_dl_version_type type, const char *key, > > +

Re: [PATCH net-next 8/9] bnxt_en: Refactor bnxt_dl_info_get().

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 06:23:00 -0400 Michael Chan wrote: > +static int bnxt_dl_info_put(struct bnxt *bp, struct devlink_info_req *req, > + enum bnxt_dl_version_type type, const char *key, > + char *buf) > +{ > + if (!strlen(buf)) > + ret

[PATCH net-next 8/9] bnxt_en: Refactor bnxt_dl_info_get().

2020-10-11 Thread Michael Chan
From: Vasundhara Volam Add a new function bnxt_dl_info_put() to simplify the code, as there are more stored firmware version fields to be added in the next patch. Also, rename fw_ver variable name to ncsi_ver for better naming while copying to devlink info_get cb. Reviewed-by: Pavan Chebbi Rev