Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Andrew Lunn
> Looks like a plan. So, I will remove the adjust_link speed > selection for > 1g and the C45 support. I will leave the SS > selection in dwxgmac2_core_init (patch 2/9) as this makes no > difference because only 1g will be selected for now. I will also > clearly refer in cover letter the BW results

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Jose Abreu
On 02-08-2018 15:36, Andrew Lunn wrote: >> Sorry, I made a mistake. Where it reads SGMII in my reply I was >> referring to XGMII. > So you have XGMII between the MAC and the PHY. That should support > 2.5G, 5G and 10G. What i don't know is if you can also do 10/100/1000 > over XGMII? Acording to d

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Andrew Lunn
> Sorry, I made a mistake. Where it reads SGMII in my reply I was > referring to XGMII. So you have XGMII between the MAC and the PHY. That should support 2.5G, 5G and 10G. What i don't know is if you can also do 10/100/1000 over XGMII? How are you currently connecting your 1G PHY to the MAC? XGM

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Jose Abreu
Hi Andrew, On 02-08-2018 15:03, Andrew Lunn wrote: > On Thu, Aug 02, 2018 at 09:26:28AM +0100, Jose Abreu wrote: >> Hi Andrew, >> >> Thanks for the review! >> >> On 01-08-2018 16:23, Andrew Lunn wrote: @@ -842,6 +863,12 @@ static void stmmac_adjust_link(struct net_device *dev)

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Andrew Lunn
On Thu, Aug 02, 2018 at 09:26:28AM +0100, Jose Abreu wrote: > Hi Andrew, > > Thanks for the review! > > On 01-08-2018 16:23, Andrew Lunn wrote: > >> @@ -842,6 +863,12 @@ static void stmmac_adjust_link(struct net_device *dev) > >>new_state = true; > >>ctrl &

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-02 Thread Jose Abreu
Hi Andrew, Thanks for the review! On 01-08-2018 16:23, Andrew Lunn wrote: >> @@ -842,6 +863,12 @@ static void stmmac_adjust_link(struct net_device *dev) >> new_state = true; >> ctrl &= ~priv->hw->link.speed_mask; >> switch (phydev->sp

Re: [PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-01 Thread Andrew Lunn
> @@ -842,6 +863,12 @@ static void stmmac_adjust_link(struct net_device *dev) > new_state = true; > ctrl &= ~priv->hw->link.speed_mask; > switch (phydev->speed) { > + case SPEED_1: > +

[PATCH net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow

2018-08-01 Thread Jose Abreu
Now that we have all the XGMAC related callbacks, lets start integrating this IP block into main driver. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 55 ++-