RE: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-03-03 Thread Parav Pandit
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jiri Pirko > Sent: Wednesday, February 27, 2019 7:08 AM > To: Jakub Kicinski > Cc: da...@davemloft.net; oss-driv...@netronome.com; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-03-01 Thread Jakub Kicinski
On Fri, 1 Mar 2019 08:37:00 +0100, Jiri Pirko wrote: > >> >I do not think that every netdev should have a devlink port associated. > >> > > >> >> Not sure about VF. > >> >> > >> >> Consider a simple problem of setting up a VF mac address. In legacy, you > >> >> do it like this: > >> >> $ ip li

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-28 Thread Jiri Pirko
Thu, Feb 28, 2019 at 05:36:44PM CET, jakub.kicin...@netronome.com wrote: >On Thu, 28 Feb 2019 10:00:54 +0100, Jiri Pirko wrote: >> Wed, Feb 27, 2019 at 07:47:42PM CET, jakub.kicin...@netronome.com wrote: >> >On Wed, 27 Feb 2019 14:08:29 +0100, Jiri Pirko wrote: >> >> Tue, Feb 26, 2019 at 07:24:34

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-28 Thread Jakub Kicinski
On Thu, 28 Feb 2019 10:00:54 +0100, Jiri Pirko wrote: > Wed, Feb 27, 2019 at 07:47:42PM CET, jakub.kicin...@netronome.com wrote: > >On Wed, 27 Feb 2019 14:08:29 +0100, Jiri Pirko wrote: > >> Tue, Feb 26, 2019 at 07:24:34PM CET, jakub.kicin...@netronome.com wrote: > >> >Devlink ports represent p

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-28 Thread Jiri Pirko
Wed, Feb 27, 2019 at 07:47:42PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 27 Feb 2019 14:08:29 +0100, Jiri Pirko wrote: >> Tue, Feb 26, 2019 at 07:24:34PM CET, jakub.kicin...@netronome.com wrote: >> >Devlink ports represent ports of a switch device (or SR-IOV >> >NIC which has an embedded s

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-27 Thread Jakub Kicinski
On Wed, 27 Feb 2019 14:08:29 +0100, Jiri Pirko wrote: > Tue, Feb 26, 2019 at 07:24:34PM CET, jakub.kicin...@netronome.com wrote: > >Devlink ports represent ports of a switch device (or SR-IOV > >NIC which has an embedded switch). In case of SR-IOV when > >PCIe PFs are exposed the PFs which are dire

Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-27 Thread Jiri Pirko
Tue, Feb 26, 2019 at 07:24:34PM CET, jakub.kicin...@netronome.com wrote: >Devlink ports represent ports of a switch device (or SR-IOV >NIC which has an embedded switch). In case of SR-IOV when >PCIe PFs are exposed the PFs which are directly connected >to the local machine may also spawn PF netdev

[PATCH net-next 6/8] devlink: introduce port's peer netdevs

2019-02-26 Thread Jakub Kicinski
Devlink ports represent ports of a switch device (or SR-IOV NIC which has an embedded switch). In case of SR-IOV when PCIe PFs are exposed the PFs which are directly connected to the local machine may also spawn PF netdev (much like VFs have a port/"repr" and an actual VF netdev). Allow devlink to