Re: [PATCH net-next 6/7] bnxt_en: Implement xmit_more.

2017-05-29 Thread Michael Chan
On Mon, May 29, 2017 at 8:28 PM, Mintz, Yuval wrote: > >> - bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod); >> + if (!skb->xmit_more) >> + bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod); > > DQL can prevent you from getting the xmit_more marked SKB, > so you

Re: [PATCH net-next 6/7] bnxt_en: Implement xmit_more.

2017-05-29 Thread Mintz, Yuval
> -   bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod); > +   if (!skb->xmit_more) > +   bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod); DQL can prevent you from getting the xmit_more marked SKB, so you should probably also check for netif_xmit_stopped().

[PATCH net-next 6/7] bnxt_en: Implement xmit_more.

2017-05-29 Thread Michael Chan
Do not write the TX doorbell if skb->xmit_more is set unless the TX queue is full. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/