Re: [PATCH net-next 5/8] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-14 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > int mv88e6xxx_set_addr_indirect(struct dsa_switch *ds, u8 *addr) > { > + int ret, err; > int i; > - int ret; > > for (i = 0; i < 6; i++) { > int j; > > /* Write the MAC address byte. */ > - REG_W

[PATCH net-next 5/8] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-13 Thread Andrew Lunn
These macros hide a ds variable and a return statement on error, which can lead to locking issues. Kill them off. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 13 ++- drivers/net/dsa/mv88e6131.c | 41 drivers/net/dsa/mv88e6171.c | 16 +-- drivers/net/dsa/mv88e6352.c |