Re: [PATCH net-next 5/6] net: hns3: use writel() to optimize the barrier operation

2020-09-14 Thread Yunsheng Lin
On 2020/9/15 5:45, Jakub Kicinski wrote: > On Mon, 14 Sep 2020 20:06:56 +0800 Huazhong Tan wrote: >> From: Yunsheng Lin >> >> writel() can be used to order I/O vs memory by default when >> writing portable drivers. Use writel() to replace wmb() + >> writel_relaxed(), and writel() is dma_wmb() + wr

Re: [PATCH net-next 5/6] net: hns3: use writel() to optimize the barrier operation

2020-09-14 Thread Jakub Kicinski
On Mon, 14 Sep 2020 20:06:56 +0800 Huazhong Tan wrote: > From: Yunsheng Lin > > writel() can be used to order I/O vs memory by default when > writing portable drivers. Use writel() to replace wmb() + > writel_relaxed(), and writel() is dma_wmb() + writel_relaxed() > for ARM64, so there is an opti

[PATCH net-next 5/6] net: hns3: use writel() to optimize the barrier operation

2020-09-14 Thread Huazhong Tan
From: Yunsheng Lin writel() can be used to order I/O vs memory by default when writing portable drivers. Use writel() to replace wmb() + writel_relaxed(), and writel() is dma_wmb() + writel_relaxed() for ARM64, so there is an optimization here because dma_wmb() is a lighter barrier than wmb(). S