RE: [PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-19 Thread Yuval Mintz
> >> The third option I see is to completely ditch this, stating that > >> although We obviously CAN set the non-volatile memory we CAN'T do it > >> with the regular API, and to move into doing this via some > >> proprietary API such as debugfs. > > > Why go to debugfs rather than gracefully exten

Re: [PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-17 Thread Yuval Mintz
>> The third option I see is to completely ditch this, stating that although >> We obviously CAN set the non-volatile memory we CAN'T do it with the >> regular API, and to move into doing this via some proprietary API such >> as debugfs. > Why go to debugfs rather than gracefully extending the eth

RE: [PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-17 Thread Yuval Mintz
> > There's quite a bit of `magic' here [based on the ethtool `magic' > > field] which is retained by the user application responsible for > > interacting with the driver for the purpose of upgrading the nvram > > image. > > This is not how the 'magic' value of the eeprom structure is specified to

Re: [PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-17 Thread David Miller
From: Yuval Mintz Date: Mon, 18 Apr 2016 03:59:42 + > The third option I see is to completely ditch this, stating that although > We obviously CAN set the non-volatile memory we CAN'T do it with the > regular API, and to move into doing this via some proprietary API such > as debugfs. Why go

Re: [PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-17 Thread David Miller
From: Yuval Mintz Date: Sun, 17 Apr 2016 22:26:35 +0300 > There's quite a bit of `magic' here [based on the ethtool `magic' > field] which is retained by the user application responsible for > interacting with the driver for the purpose of upgrading the nvram > image. This is not how the 'magic'

[PATCH net-next 5/5] qed*: Add support for read/write of eeprom

2016-04-17 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru Add the driver logic needed for supporting the ethtool APIs for reading and writing from the interface's eeprom. There's quite a bit of `magic' here [based on the ethtool `magic' field] which is retained by the user application responsible for interacting with the d