Re: [PATCH net-next 5/5] phy: fixed: Fix removal of phys.

2016-03-12 Thread Andrew Lunn
> > +void fixed_phy_unregister(struct phy_device *phy) > > +{ > > + phy_device_remove(phy); > > + > > + fixed_phy_del(phy->mdio.addr); > > fixed_phy_del() should also make sure that there is no dangling > link_update callback registered, even though this is not fatal, as it > checks whether th

Re: [PATCH net-next 5/5] phy: fixed: Fix removal of phys.

2016-03-11 Thread Florian Fainelli
On 11/03/16 15:01, Andrew Lunn wrote: > The fixed phys delete function simply removed the fixed phy from the > internal linked list and freed the memory. It however did not > unregister the associated phy device. This meant it was still possible > to find the phy device on the mdio bus. > > Make f

[PATCH net-next 5/5] phy: fixed: Fix removal of phys.

2016-03-11 Thread Andrew Lunn
The fixed phys delete function simply removed the fixed phy from the internal linked list and freed the memory. It however did not unregister the associated phy device. This meant it was still possible to find the phy device on the mdio bus. Make fixed_phy_del() an internal function and add a fixe