Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

2018-01-28 Thread Willem de Bruijn
On Sun, Jan 28, 2018 at 5:15 PM, Sowmini Varadhan wrote: > > thanks for taking the time to go through the code! > >> >> An alternative that does not require a timer is to batch on the sk >> error queue itself, like tcp zerocopy. That queues the first notification >> skb on the error queue without

Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

2018-01-28 Thread Sowmini Varadhan
thanks for taking the time to go through the code! > > An alternative that does not require a timer is to batch on the sk > error queue itself, like tcp zerocopy. That queues the first notification > skb on the error queue without any notification latency. > > Then, if a subsequent notification

Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

2018-01-28 Thread Willem de Bruijn
On Wed, Jan 24, 2018 at 12:45 PM, Sowmini Varadhan wrote: > RDS removes a datagram (rds_message) from the retransmit queue when > an ACK is received. The ACK indicates that the receiver has queued > the RDS datagram, so that the sender can safely forget the datagram. > When all references to the r

[PATCH net-next 4/7] rds: support for zcopy completion notification

2018-01-24 Thread Sowmini Varadhan
RDS removes a datagram (rds_message) from the retransmit queue when an ACK is received. The ACK indicates that the receiver has queued the RDS datagram, so that the sender can safely forget the datagram. When all references to the rds_message are quiesced, rds_message_purge is called to release res