Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-08 Thread Andrew Lunn
> > Hi Vivien > > > > Bike shedding a bit, but i would call this > > mv88e6xxx_port_fdb_prepare_add. > > I think port_fdb_prepare is fine because it is the only step that > actually needs the 2-phase model. del and dump are safe and don't need > pre-check. O.K. I don't have a strong opinion, i j

Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-08 Thread Vivien Didelot
Hi Andrew, On Oct. Thursday 08 (41) 02:25 AM, Andrew Lunn wrote: > On Wed, Oct 07, 2015 at 07:48:29PM -0400, Vivien Didelot wrote: > > Push the prepare phase for FDB operations down to the DSA drivers, with > > a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > > > > Signed-

Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-07 Thread Scott Feldman
On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot wrote: > Push the prepare phase for FDB operations down to the DSA drivers, with > a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > > Signed-off-by: Vivien Didelot Reviewed-by: Scott Feldman -- To unsubscribe from this list:

Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-07 Thread Andrew Lunn
On Wed, Oct 07, 2015 at 07:48:29PM -0400, Vivien Didelot wrote: > Push the prepare phase for FDB operations down to the DSA drivers, with > a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6171.c | 1 + > drive

[PATCH net-next 4/6] net: dsa: add port_fdb_prepare

2015-10-07 Thread Vivien Didelot
Push the prepare phase for FDB operations down to the DSA drivers, with a new port_fdb_prepare function. Currently only mv88e6xxx is affected. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + drivers/net/dsa/mv88e6xxx.c | 10 ++ dr