Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 03:26:56PM +, Jose Abreu wrote: > On 3/3/2019 4:12 PM, Heiner Kallweit wrote: > > Not sure whether anybody is relying on the gen10g driver currently. > > I do for stmmac (code not upstreamed yet) and it works okay. For > debug purposes I ended up writing my own phy driv

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-04 Thread Jose Abreu
On 3/3/2019 4:12 PM, Heiner Kallweit wrote: > Not sure whether anybody is relying on the gen10g driver currently. I do for stmmac (code not upstreamed yet) and it works okay. For debug purposes I ended up writing my own phy driver but this is a plain copy of Generic 10G driver + reset and suspend/

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-03 Thread Heiner Kallweit
On 03.03.2019 16:58, Andrew Lunn wrote: > On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote: >> gen10g_read_status is deprecated, therefore stop exporting it. >> We don't want to encourage anybody to use it. > > Hi Florian, Heiner > Hi Andrew, > We should consider what we want to d

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-03 Thread Andrew Lunn
On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote: > gen10g_read_status is deprecated, therefore stop exporting it. > We don't want to encourage anybody to use it. Hi Florian, Heiner We should consider what we want to do with the generic 10G driver. Can a c45 PHY be expected to wor

Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-03 Thread Andrew Lunn
On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote: > gen10g_read_status is deprecated, therefore stop exporting it. > We don't want to encourage anybody to use it. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew

[PATCH net-next 4/5] net: phy: don't export gen10g_read_status

2019-03-02 Thread Heiner Kallweit
gen10g_read_status is deprecated, therefore stop exporting it. We don't want to encourage anybody to use it. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 3 +-- include/linux/phy.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/phy/phy-c4