Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Daniel Jurgens
On 1/16/2017 3:59 PM, Or Gerlitz wrote: > On Mon, Jan 16, 2017 at 11:54 PM, Daniel Jurgens wrote: >> On 1/16/2017 3:44 PM, Or Gerlitz wrote: >>> On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: From: Daniel Jurgens Use CPUs on the close NUMA when setting the EQ affinity hints.

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 11:54 PM, Daniel Jurgens wrote: > On 1/16/2017 3:44 PM, Or Gerlitz wrote: >> On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: >>> From: Daniel Jurgens >>> >>> Use CPUs on the close NUMA when setting the EQ affinity hints. >> Dan, are we sure there are no down-sides fo

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread David Miller
From: Daniel Jurgens Date: Mon, 16 Jan 2017 21:54:36 + > I don't understand your 2nd sentence there. "Ms installs"? I think he meant "Mellanox's installs", meaning installations of Linux using Mellanox hardware. At least that's how I read it.

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Daniel Jurgens
On 1/16/2017 3:44 PM, Or Gerlitz wrote: > On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: >> From: Daniel Jurgens >> >> Use CPUs on the close NUMA when setting the EQ affinity hints. > Dan, are we sure there are no down-sides for always doing this? this > code is probably there for many year

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: > From: Daniel Jurgens > > Use CPUs on the close NUMA when setting the EQ affinity hints. Dan, are we sure there are no down-sides for always doing this? this code is probably there for many years and we're introducing here new behaviour to po

[PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Tariq Toukan
From: Daniel Jurgens Use CPUs on the close NUMA when setting the EQ affinity hints. Signed-off-by: Daniel Jurgens Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/