Re: [PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links

2020-08-03 Thread Stefano Brivio
On Mon, 3 Aug 2020 17:48:48 -0600 David Ahern wrote: > On 8/3/20 2:52 PM, Stefano Brivio wrote: > > + err = skb_tunnel_check_pmtu(skb, ndst, VXLAN_HEADROOM, > > + netif_is_bridge_port(dev) || > > + netif_is_ovs_

Re: [PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links

2020-08-03 Thread David Ahern
On 8/3/20 2:52 PM, Stefano Brivio wrote: > + err = skb_tunnel_check_pmtu(skb, ndst, VXLAN_HEADROOM, > + netif_is_bridge_port(dev) || > + netif_is_ovs_port(dev)); you have this check in a few places. Maybe a

[PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links

2020-08-03 Thread Stefano Brivio
If the interface is a bridge or Open vSwitch port, and we can't forward a packet because it exceeds the local PMTU estimate, trigger an ICMP or ICMPv6 reply to the sender, using the same interface to forward it back. If metadata collection is enabled, reverse destination and source addresses, so t