Thanks guys for the review.
For completeness, I'll add smp_wmb() here :
gact->tcfg_pval= max_t(u16, 1, p_parm->pval);
smp_wmb();
gact->tcfg_ptype = p_parm->ptype;
And corresponding smp_rmb()
On Fri, Jul 3, 2015 at 12:49 PM, Jamal Hadi Salim wrote:
> On 07/02/15 09:07, Eric Du
On 07/02/15 09:07, Eric Dumazet wrote:
First step for gact RCU operation :
Instead of testing if tcfg_pval is zero or not, just make it 1.
No change in behavior, but slightly faster code.
Signed-off-by: Eric Dumazet
Acked-by: Jamal Hadi Salim
cheers,
jamal
--
To unsubscribe from this lis
On 7/2/15 6:07 AM, Eric Dumazet wrote:
First step for gact RCU operation :
Instead of testing if tcfg_pval is zero or not, just make it 1.
No change in behavior, but slightly faster code.
Signed-off-by: Eric Dumazet
Nice trick!
Acked-by: Alexei Starovoitov
--
To unsubscribe from this list:
On 15-07-02 06:07 AM, Eric Dumazet wrote:
> First step for gact RCU operation :
>
> Instead of testing if tcfg_pval is zero or not, just make it 1.
>
> No change in behavior, but slightly faster code.
>
> Signed-off-by: Eric Dumazet
> Cc: Alexei Starovoitov
> Cc: Jamal Hadi Salim
> Cc: John F
First step for gact RCU operation :
Instead of testing if tcfg_pval is zero or not, just make it 1.
No change in behavior, but slightly faster code.
Signed-off-by: Eric Dumazet
Cc: Alexei Starovoitov
Cc: Jamal Hadi Salim
Cc: John Fastabend
---
net/sched/act_gact.c | 6 +++---
1 file changed
