Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 10:59:55AM -0700, Florian Fainelli wrote: > Hi Andrew, > > On 03/18/2018 12:19 PM, Andrew Lunn wrote: > >> +static int dsa_slave_nway_reset(struct net_device *dev) > >> +{ > >> + struct dsa_port *dp = dsa_slave_to_port(dev); > >> + > >> + return phylink_ethtool_nway_reset

Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support

2018-03-19 Thread Florian Fainelli
On 03/19/2018 11:09 AM, Russell King - ARM Linux wrote: > On Mon, Mar 19, 2018 at 10:59:55AM -0700, Florian Fainelli wrote: >> Hi Andrew, >> >> On 03/18/2018 12:19 PM, Andrew Lunn wrote: +static int dsa_slave_nway_reset(struct net_device *dev) +{ + struct dsa_port *dp = dsa_slave_to

Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support

2018-03-19 Thread Florian Fainelli
Hi Andrew, On 03/18/2018 12:19 PM, Andrew Lunn wrote: >> +static int dsa_slave_nway_reset(struct net_device *dev) >> +{ >> +struct dsa_port *dp = dsa_slave_to_port(dev); >> + >> +return phylink_ethtool_nway_reset(dp->pl); >> +} > > Hi Florian > > I've seen in one of Russells trees a patc

Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support

2018-03-18 Thread Andrew Lunn
> +static int dsa_slave_nway_reset(struct net_device *dev) > +{ > + struct dsa_port *dp = dsa_slave_to_port(dev); > + > + return phylink_ethtool_nway_reset(dp->pl); > +} Hi Florian I've seen in one of Russells trees a patch to put a phylink into net_device. That would make a generic slave

[PATCH net-next 3/4] net: dsa: Plug in PHYLINK support

2018-03-18 Thread Florian Fainelli
Add support for PHYLINK within the DSA subsystem in order to support more complex devices such as pluggable (SFP) and non-pluggable (SFF) modules, 10G PHYs, and traditional PHYs. Using PHYLINK allows us to drop some amount of complexity we had while probing fixed and non-fixed PHYs using Device Tre