Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset

2018-01-04 Thread Guillaume Nault
On Thu, Jan 04, 2018 at 12:36:26PM +, James Chapman wrote: > On 04/01/18 10:25, Guillaume Nault wrote: > >> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c > >> index eb69411..2c30587 100644 > >> --- a/net/l2tp/l2tp_debugfs.c > >> +++ b/net/l2tp/l2tp_debugfs.c > >> @@ -180,8 +180

Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset

2018-01-04 Thread James Chapman
On 04/01/18 10:25, Guillaume Nault wrote: >> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c >> index eb69411..2c30587 100644 >> --- a/net/l2tp/l2tp_debugfs.c >> +++ b/net/l2tp/l2tp_debugfs.c >> @@ -180,8 +180,8 @@ static void l2tp_dfs_seq_session_show(struct seq_file >> *m, void *v

Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset

2018-01-04 Thread Guillaume Nault
> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c > index eb69411..2c30587 100644 > --- a/net/l2tp/l2tp_debugfs.c > +++ b/net/l2tp/l2tp_debugfs.c > @@ -180,8 +180,8 @@ static void l2tp_dfs_seq_session_show(struct seq_file *m, > void *v) > session->lns_mode ? "LNS" :

[PATCH net-next 3/4] l2tp: remove configurable payload offset

2018-01-03 Thread James Chapman
If L2TP_ATTR_OFFSET is set to a non-zero value in L2TPv3 tunnels, it results in L2TPv3 packets being transmitted which might not be compliant with the L2TPv3 RFC. This patch has l2tp ignore the offset setting and send all packets with no offset. In more detail: L2TPv2 supports a variable offset f