On Tue, May 15, 2018 at 7:57 PM, Willem de Bruijn
wrote:
> On Tue, May 15, 2018 at 4:04 PM, Willem de Bruijn
> wrote:
>> On Tue, May 15, 2018 at 10:14 AM, Willem de Bruijn
>> wrote:
>>> On Mon, May 14, 2018 at 7:45 PM, Eric Dumazet
>>> wrote:
On 05/14/2018 04:30 PM, Willem de Br
On Tue, May 15, 2018 at 4:04 PM, Willem de Bruijn
wrote:
> On Tue, May 15, 2018 at 10:14 AM, Willem de Bruijn
> wrote:
>> On Mon, May 14, 2018 at 7:45 PM, Eric Dumazet wrote:
>>>
>>>
>>> On 05/14/2018 04:30 PM, Willem de Bruijn wrote:
>>>
I don't quite follow. The reported crash happens in
On Tue, May 15, 2018 at 10:14 AM, Willem de Bruijn
wrote:
> On Mon, May 14, 2018 at 7:45 PM, Eric Dumazet wrote:
>>
>>
>> On 05/14/2018 04:30 PM, Willem de Bruijn wrote:
>>
>>> I don't quite follow. The reported crash happens in the protocol layer,
>>> because of this check. With pagedlen we have
On Mon, May 14, 2018 at 7:45 PM, Eric Dumazet wrote:
>
>
> On 05/14/2018 04:30 PM, Willem de Bruijn wrote:
>
>> I don't quite follow. The reported crash happens in the protocol layer,
>> because of this check. With pagedlen we have not allocated
>> sufficient space for the skb_put.
>>
>>
On 05/14/2018 04:30 PM, Willem de Bruijn wrote:
> I don't quite follow. The reported crash happens in the protocol layer,
> because of this check. With pagedlen we have not allocated
> sufficient space for the skb_put.
>
> if (!(rt->dst.dev->features&NETIF_F_SG)) {
>
On Mon, May 14, 2018 at 7:12 PM, Eric Dumazet wrote:
>
>
> On 05/14/2018 04:07 PM, Willem de Bruijn wrote:
>> From: Willem de Bruijn
>>
>> Paged allocation stores most payload in skb frags. This helps udp gso
>> by avoiding copying from the gso skb to segment skb in skb_segment.
>>
>> But without
On 05/14/2018 04:07 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Paged allocation stores most payload in skb frags. This helps udp gso
> by avoiding copying from the gso skb to segment skb in skb_segment.
>
> But without scatter-gather, data must be linear, so do not use paged
> mo
From: Willem de Bruijn
Paged allocation stores most payload in skb frags. This helps udp gso
by avoiding copying from the gso skb to segment skb in skb_segment.
But without scatter-gather, data must be linear, so do not use paged
mode unless NETIF_F_SG.
Fixes: 15e36f5b8e98 ("udp: paged allocati
