Re: [PATCH net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-dccp-make-our-listener-code-more-robust/20151015-020006 reproduce: # apt-get i

Re: [PATCH net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread Eric Dumazet
On Wed, 2015-10-14 at 10:58 -0700, Eric Dumazet wrote: ... > diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c > index a5a1b54915e5..38b7ef8b0b78 100644 > --- a/net/ipv4/inet_connection_sock.c > +++ b/net/ipv4/inet_connection_sock.c > @@ -740,7 +740,7 @@ int inet_cs

[PATCH net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread Eric Dumazet
Under stress, a close() on a listener can trigger the WARN_ON(sk->sk_ack_backlog) in inet_csk_listen_stop() We need to test if listener is still active before queueing a child in inet_csk_reqsk_queue_add() Create a common inet_child_forget() helper, and use it from inet_csk_reqsk_queue_add() and