Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-11 Thread Andrew Lunn
> The test currently resides under > tools/testing/selftests/drivers/net/mlxsw/, so it's specific to mlxsw. > > I believe the 56G quirk is the only thing in the test that is specific > to mlxsw. Should be possible to move it to > tools/testing/selftests/net/forwarding/ and skip 56G for mlxsw. Hi

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-11 Thread Ido Schimmel
On Tue, Jun 11, 2019 at 02:22:55PM +0200, Andrew Lunn wrote: > On Tue, Jun 11, 2019 at 09:35:26AM +0300, Ido Schimmel wrote: > > On Mon, Jun 10, 2019 at 04:06:33PM +0200, Andrew Lunn wrote: > > > On Mon, Jun 10, 2019 at 04:58:48PM +0300, Ido Schimmel wrote: > > > > On Mon, Jun 10, 2019 at 03:48:20P

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-11 Thread Andrew Lunn
On Tue, Jun 11, 2019 at 09:35:26AM +0300, Ido Schimmel wrote: > On Mon, Jun 10, 2019 at 04:06:33PM +0200, Andrew Lunn wrote: > > On Mon, Jun 10, 2019 at 04:58:48PM +0300, Ido Schimmel wrote: > > > On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote: > > > > > + # Skip 56G becaus

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-10 Thread Ido Schimmel
On Mon, Jun 10, 2019 at 04:06:33PM +0200, Andrew Lunn wrote: > On Mon, Jun 10, 2019 at 04:58:48PM +0300, Ido Schimmel wrote: > > On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote: > > > > + # Skip 56G because this speed isn't supported with > > > > autoneg off. > > > > +

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-10 Thread Andrew Lunn
On Mon, Jun 10, 2019 at 04:58:48PM +0300, Ido Schimmel wrote: > On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote: > > > + # Skip 56G because this speed isn't supported with autoneg off. > > > + if [[ $speed == 56000 ]]; then > > > + continue > > > +

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-10 Thread Ido Schimmel
On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote: > > + # Skip 56G because this speed isn't supported with autoneg off. > > + if [[ $speed == 56000 ]]; then > > + continue > > + fi > > Interesting. How is 56000 represented in ethtool? List

Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-10 Thread Andrew Lunn
> + # Skip 56G because this speed isn't supported with autoneg off. > + if [[ $speed == 56000 ]]; then > + continue > + fi Interesting. How is 56000 represented in ethtool? Listed in both "Supported link modes" and "Advertised link modes"? T

[PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test

2019-06-10 Thread Ido Schimmel
From: Amit Cohen Check configurations and packets transference with different variations of autoneg and speed. Test plan: 1. Test force of same speed with autoneg off 2. Test force of different speeds with autoneg off (should fail) 3. One side is autoneg on and other side sets force of common sp