Re: [PATCH net-next 2/7] net: korina: Use devres functions

2021-04-14 Thread Andrew Lunn
> + if (!p) { > printk(KERN_ERR DRV_NAME ": cannot remap registers\n"); > - rc = -ENXIO; > - goto probe_err_out; > + return -ENOMEM; > } Hi Thomas Another possible cleanup would be replacing printk(KERN_ERR with dev_err(), or netdev_err(

[PATCH net-next 2/7] net: korina: Use devres functions

2021-04-13 Thread Thomas Bogendoerfer
Simplify probe/remove code by using devm_ functions. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 64 --- 1 file changed, 21 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index