On Fri, Oct 30, 2020 at 2:14 PM Edward Cree wrote:
>
> On 30/10/2020 17:33, Willem de Bruijn wrote:
> > On Fri, Oct 30, 2020 at 12:43 PM Edward Cree wrote:
> >> But possibly I don't need to have NETIF_F_GSO_UDP_TUNNEL[_CSUM] in
> >> net_dev->gso_partial_features?
> > If the device can handle fix
On 30/10/2020 17:33, Willem de Bruijn wrote:
> On Fri, Oct 30, 2020 at 12:43 PM Edward Cree wrote:
>> But possibly I don't need to have NETIF_F_GSO_UDP_TUNNEL[_CSUM] in
>> net_dev->gso_partial_features?
> If the device can handle fixing the odd last segment length, indeed.
It can, but...
I though
On Fri, Oct 30, 2020 at 12:43 PM Edward Cree wrote:
>
> On 30/10/2020 16:26, Willem de Bruijn wrote:
> > Then you could (as follow-up) advertise without GSO_PARTIAL and avoid
> > the whole transition through the gso layer?
>
> The thing is, non-PARTIAL offload only supports tunnels that the NIC
>
On 30/10/2020 16:26, Willem de Bruijn wrote:
> Then you could (as follow-up) advertise without GSO_PARTIAL and avoid
> the whole transition through the gso layer?
The thing is, non-PARTIAL offload only supports tunnels that the NIC
understands (single-layer UDP tunnels), but AIUI GSO_PARTIAL can
On Fri, Oct 30, 2020 at 12:16 PM Edward Cree wrote:
>
> On 30/10/2020 15:49, Willem de Bruijn wrote:
> > On Wed, Oct 28, 2020 at 9:39 PM Edward Cree wrote:
> >> + ESF_GZ_TX_TSO_ED_OUTER_UDP_LEN, encap &&
> >> !gso_partial,
> >
> > This is a boolean field to signal whe
On 30/10/2020 15:49, Willem de Bruijn wrote:
> On Wed, Oct 28, 2020 at 9:39 PM Edward Cree wrote:
>> + ESF_GZ_TX_TSO_ED_OUTER_UDP_LEN, encap &&
>> !gso_partial,
>
> This is a boolean field to signal whether the NIC needs to fix up the
> udp length field ?
Yes.
> Whic
On Wed, Oct 28, 2020 at 9:39 PM Edward Cree wrote:
>
> The NIC only needs to know where the headers it has to edit (TCP and
> inner and outer IPv4) are, which fits GSO_PARTIAL nicely.
> It also supports non-PARTIAL offload of UDP tunnels, again just
> needing to be told the outer transport offse
The NIC only needs to know where the headers it has to edit (TCP and
inner and outer IPv4) are, which fits GSO_PARTIAL nicely.
It also supports non-PARTIAL offload of UDP tunnels, again just
needing to be told the outer transport offset so that it can edit
the UDP length field.
(It's not clear t
