Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Jesper Dangaard Brouer
On Thu, 29 Oct 2020 11:31:48 +0100 Lorenzo Bianconi wrote: > > On Tue, 27 Oct 2020 20:04:08 +0100 > > Lorenzo Bianconi wrote: > > > > > +void page_pool_put_page_bulk(struct page_pool *pool, void **data, > > > + int count) > > > +{ > > > + struct page *page_ring[XDP_BULK_Q

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Lorenzo Bianconi
> On Tue, Oct 27, 2020 at 08:04:08PM +0100, Lorenzo Bianconi wrote: > > Introduce the capability to batch page_pool ptr_ring refill since it is > > usually run inside the driver NAPI tx completion loop. > > > > Suggested-by: Jesper Dangaard Brouer > > Signed-off-by: Lorenzo Bianconi > > --- > >

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Lorenzo Bianconi
> Hi Lorenzo, > > On Tue, Oct 27, 2020 at 08:04:08PM +0100, Lorenzo Bianconi wrote: > > Introduce the capability to batch page_pool ptr_ring refill since it is > > usually run inside the driver NAPI tx completion loop. > > > > Suggested-by: Jesper Dangaard Brouer > > Signed-off-by: Lorenzo Bian

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Lorenzo Bianconi
> On Tue, 27 Oct 2020 20:04:08 +0100 > Lorenzo Bianconi wrote: > > > +void page_pool_put_page_bulk(struct page_pool *pool, void **data, > > +int count) > > +{ > > + struct page *page_ring[XDP_BULK_QUEUE_SIZE]; > > Maybe we could reuse the 'data' array instead of creatin

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Jesper Dangaard Brouer
On Tue, 27 Oct 2020 20:04:08 +0100 Lorenzo Bianconi wrote: > +void page_pool_put_page_bulk(struct page_pool *pool, void **data, > + int count) > +{ > + struct page *page_ring[XDP_BULK_QUEUE_SIZE]; Maybe we could reuse the 'data' array instead of creating a new array

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Ilias Apalodimas
Hi Lorenzo, On Tue, Oct 27, 2020 at 08:04:08PM +0100, Lorenzo Bianconi wrote: > Introduce the capability to batch page_pool ptr_ring refill since it is > usually run inside the driver NAPI tx completion loop. > > Suggested-by: Jesper Dangaard Brouer > Signed-off-by: Lorenzo Bianconi > --- > i

Re: [PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-29 Thread Ilias Apalodimas
On Tue, Oct 27, 2020 at 08:04:08PM +0100, Lorenzo Bianconi wrote: > Introduce the capability to batch page_pool ptr_ring refill since it is > usually run inside the driver NAPI tx completion loop. > > Suggested-by: Jesper Dangaard Brouer > Signed-off-by: Lorenzo Bianconi > --- > include/net/pag

[PATCH net-next 2/4] net: page_pool: add bulk support for ptr_ring

2020-10-27 Thread Lorenzo Bianconi
Introduce the capability to batch page_pool ptr_ring refill since it is usually run inside the driver NAPI tx completion loop. Suggested-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- include/net/page_pool.h | 26 ++ net/core/page_pool.c| 33 +