Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Marcin Wojtas
pon., 21 gru 2020 o 20:07 Sasha Levin napisał(a): > > On Mon, Dec 21, 2020 at 10:47:57AM -0800, Jakub Kicinski wrote: > >On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: > >> On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > >> > We need to work with stable

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Sasha Levin
On Mon, Dec 21, 2020 at 10:47:57AM -0800, Jakub Kicinski wrote: On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > We need to work with stable maintainers on this, let's see.. > > Greg asked for a clear descr

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Jakub Kicinski
On Mon, 21 Dec 2020 18:30:32 + Russell King - ARM Linux admin wrote: > On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > > We need to work with stable maintainers on this, let's see.. > > > > Greg asked for a clear description of what happens, from your > > previous response i

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Russell King - ARM Linux admin
On Mon, Dec 21, 2020 at 10:25:39AM -0800, Jakub Kicinski wrote: > We need to work with stable maintainers on this, let's see.. > > Greg asked for a clear description of what happens, from your > previous response it sounds like a null-deref in mvpp2_mac_config(). > Is the netdev -> config -> net

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-21 Thread Jakub Kicinski
On Sun, 20 Dec 2020 18:08:19 +0100 Marcin Wojtas wrote: > > > > > >> > > This patch fixes a regression that was introduced in v5.3: > > > > > >> > > Commit 44cc27e43fa3 ("net: phylink: Add struct phylink_config > > > > > >> > > to PHYLINK API") > > > > > >> > > > > > > > >> > > Above results in a

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-20 Thread Marcin Wojtas
Hi Jakub, czw., 10 gru 2020 o 15:35 Marcin Wojtas napisał(a): > > Hi Greg, > > śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman > napisał(a): > > > > On Tue, Dec 08, 2020 at 04:02:50PM +0100, Marcin Wojtas wrote: > > > Hi Sasha, > > > > > > wt., 8 gru 2020 o 14:35 Sasha Levin napisał(a): > > > > > >

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-11 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 06:03:57AM +0100, Jon Nettleton wrote: > On Thu, Dec 10, 2020 at 9:27 PM Andrew Lunn wrote: > > > > > +1. As soon as the MDIO+ACPI lands, I plan to do the rework. > > > > Don't hold you breath. It has gone very quiet about ACPI in net > > devices. > > NXP resources were re

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Jon Nettleton
On Thu, Dec 10, 2020 at 9:27 PM Andrew Lunn wrote: > > > +1. As soon as the MDIO+ACPI lands, I plan to do the rework. > > Don't hold you breath. It has gone very quiet about ACPI in net > devices. NXP resources were re-allocated for their next internal BSP release. I have been working with Calvin

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
czw., 10 gru 2020 o 21:26 Andrew Lunn napisał(a): > > > +1. As soon as the MDIO+ACPI lands, I plan to do the rework. > > Don't hold you breath. It has gone very quiet about ACPI in net > devices. I saw the results of the upcoming next revision from NXP, so I'm rather optimistic. Best regards, Ma

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Andrew Lunn
> +1. As soon as the MDIO+ACPI lands, I plan to do the rework. Don't hold you breath. It has gone very quiet about ACPI in net devices. Andrew

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
czw., 10 gru 2020 o 18:56 Russell King - ARM Linux admin napisał(a): > > On Thu, Dec 10, 2020 at 06:43:50PM +0100, Marcin Wojtas wrote: > > I must admit that due to other duties I did not follow the mainline > > mvpp2 for a couple revisions (and I am not maintainer of it). However > > recently I g

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Russell King - ARM Linux admin
On Thu, Dec 10, 2020 at 06:43:50PM +0100, Marcin Wojtas wrote: > I must admit that due to other duties I did not follow the mainline > mvpp2 for a couple revisions (and I am not maintainer of it). However > recently I got reached-out directly by different developers - the > trigger was different di

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
Hi Russell, czw., 10 gru 2020 o 16:46 Russell King - ARM Linux admin napisał(a): > > On Thu, Dec 10, 2020 at 03:35:29PM +0100, Marcin Wojtas wrote: > > Hi Greg, > > > > śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman > > napisał(a): > > > What part fixes the issue? I can't see it... > > > > I re-che

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
Hi Greg, śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman napisał(a): > > On Tue, Dec 08, 2020 at 04:02:50PM +0100, Marcin Wojtas wrote: > > Hi Sasha, > > > > wt., 8 gru 2020 o 14:35 Sasha Levin napisał(a): > > > > > > On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: > > > >Hi Greg, > >

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Russell King - ARM Linux admin
On Thu, Dec 10, 2020 at 03:35:29PM +0100, Marcin Wojtas wrote: > Hi Greg, > > śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman > napisał(a): > > What part fixes the issue? I can't see it... > > I re-checked in my setup and here's the smallest part of the original > patch, that fixes previously descri

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-09 Thread Greg Kroah-Hartman
On Tue, Dec 08, 2020 at 04:02:50PM +0100, Marcin Wojtas wrote: > Hi Sasha, > > wt., 8 gru 2020 o 14:35 Sasha Levin napisał(a): > > > > On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: > > >Hi Greg, > > > > > >Apologies for delayed response:. > > > > > > > > >pon., 2 lis 2020 o 19:02

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-08 Thread Marcin Wojtas
Hi Sasha, wt., 8 gru 2020 o 14:35 Sasha Levin napisał(a): > > On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: > >Hi Greg, > > > >Apologies for delayed response:. > > > > > >pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman > > napisał(a): > >> > >> On Mon, Nov 02, 2020 at 06:38:54PM +010

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-08 Thread Sasha Levin
On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: Hi Greg, Apologies for delayed response:. pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman napisał(a): On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > Hi Greg and Sasha, > > pt., 9 paź 2020 o 05:43 Marcin Wojtas nap

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-08 Thread Marcin Wojtas
Hi Greg, Apologies for delayed response:. pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman napisał(a): > > On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > > Hi Greg and Sasha, > > > > pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > > > > > Hi, > > > > > > sob., 20 cze 2020 o

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-11-02 Thread Russell King - ARM Linux admin
On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > Hi Greg and Sasha, > > pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > > > Hi, > > > > sob., 20 cze 2020 o 11:21 Russell King > > napisał(a): > > > > > > Add a helper to convert the struct phylink_config pointer passed in >

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-11-02 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > Hi Greg and Sasha, > > pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > > > Hi, > > > > sob., 20 cze 2020 o 11:21 Russell King > > napisał(a): > > > > > > Add a helper to convert the struct phylink_config pointer passed in >

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-11-02 Thread Marcin Wojtas
Hi Greg and Sasha, pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > Hi, > > sob., 20 cze 2020 o 11:21 Russell King > napisał(a): > > > > Add a helper to convert the struct phylink_config pointer passed in > > from phylink to the drivers internal struct mvpp2_port. > > > > Signed-off-by: Ru

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-10-08 Thread Marcin Wojtas
Hi, sob., 20 cze 2020 o 11:21 Russell King napisał(a): > > Add a helper to convert the struct phylink_config pointer passed in > from phylink to the drivers internal struct mvpp2_port. > > Signed-off-by: Russell King > --- > .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 29 +--

[PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-06-20 Thread Russell King
Add a helper to convert the struct phylink_config pointer passed in from phylink to the drivers internal struct mvpp2_port. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 29 +-- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/driv

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-06-19 Thread David Miller
From: Russell King Date: Thu, 18 Jun 2020 16:38:51 +0100 > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 7653277d03b7..8c8314715efd 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethern

[PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-06-18 Thread Russell King
Add a helper to convert the struct phylink_config pointer passed in from phylink to the drivers internal struct mvpp2_port. Signed-off-by: Russell King --- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/driv