Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-03 Thread Salam Noureddine
On Wed, Feb 3, 2016 at 12:08 AM, Julian Anastasov wrote: > Aha, I see, it is after NETDEV_UNREGISTER but may be > the above loop should be changed to two loops so that > NETDEV_UNREGISTER_BATCH is called exactly after all > NETDEV_UNREGISTER and before all dev_*_flush and > ndo_uninit ca

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-03 Thread Julian Anastasov
Hello, On Tue, 2 Feb 2016, Salam Noureddine wrote: > On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > > > If the rule is once per net, the above call... > > > >> } > > > > should be here: > > > > call_netd

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-02 Thread Salam Noureddine
On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > Hello, > > On Mon, 1 Feb 2016, Salam Noureddine wrote: > >> @@ -1572,8 +1582,12 @@ rollback: >> call_netdevice_notifier(nb, NETDEV_UNREGISTER, dev); >> + call_netdevice_notifier(nb, NETD

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-02 Thread Julian Anastasov
Hello, On Mon, 1 Feb 2016, Salam Noureddine wrote: > @@ -1572,8 +1582,12 @@ rollback: > call_netdevice_notifier(nb, NETDEV_GOING_DOWN, > dev); > call_netdevice_notifier(nb, N

[PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-01 Thread Salam Noureddine
This can be used to optimize bringing down and unregsitering net_devices by running certain cleanup operations only on the net namespace instead of on each net_device. Signed-off-by: Salam Noureddine --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 39 ++

[PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-01-04 Thread Salam Noureddine
This can be used to optimize bringing down and unregsitering net_devices by running certain cleanup operations only on the net namespace instead of on each net_device. Signed-off-by: Salam Noureddine --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 39 ++