Re: [PATCH net-next 2/4] net: af_unix: implement stream sendpage support

2015-05-20 Thread Hannes Frederic Sowa
On Thu, May 21, 2015, at 01:21, Eric Dumazet wrote: > On Wed, 2015-05-20 at 17:35 +0200, Hannes Frederic Sowa wrote: > > This patch implements sendpage support for AF_UNIX SOCK_STREAM > > + > > + if (newskb) > > + skb_queue_tail(&other->sk_receive_queue, newskb); > > Are you sure we ne

Re: [PATCH net-next 2/4] net: af_unix: implement stream sendpage support

2015-05-20 Thread Eric Dumazet
On Wed, 2015-05-20 at 17:35 +0200, Hannes Frederic Sowa wrote: > This patch implements sendpage support for AF_UNIX SOCK_STREAM > sockets. This is also required for a complete splice implementation. > > The implementation is a bit tricky because we append to already existing > skbs and so have to

Re: [PATCH net-next 2/4] net: af_unix: implement stream sendpage support

2015-05-20 Thread Cong Wang
On Wed, May 20, 2015 at 8:35 AM, Hannes Frederic Sowa wrote: > > +static ssize_t unix_stream_sendpage(struct socket *socket, struct page *page, > + int offset, size_t size, int flags) > +{ > + int err; > + bool send_sigpipe; > + struct sock *sk,

[PATCH net-next 2/4] net: af_unix: implement stream sendpage support

2015-05-20 Thread Hannes Frederic Sowa
This patch implements sendpage support for AF_UNIX SOCK_STREAM sockets. This is also required for a complete splice implementation. The implementation is a bit tricky because we append to already existing skbs and so have to hold unix_sk->readlock to protect the reading side from dropping the tail