RE: [PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status handling

2015-07-13 Thread Manoil Claudiu
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, July 11, 2015 4:25 AM > To: Manoil Claudiu-B08782 > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status > handling > > From:

Re: [PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status handling

2015-07-10 Thread David Miller
From: Claudiu Manoil Date: Thu, 9 Jul 2015 19:24:42 +0300 > @@ -2921,6 +2921,7 @@ int gfar_clean_rx_ring(struct gfar_priv_rx_q *rx_queue, > int rx_work_limit) > i = rx_queue->next_to_clean; > > while (rx_work_limit--) { > + unsigned long lstatus; > > if

[PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status handling

2015-07-09 Thread Claudiu Manoil
There are several (long standing) problems about how the status field of the rx buffer descriptor (rxbd) is currently handled on the error path: - too many unnecessary 16bit reads of the two halves of the rxbd status field (32bit), also resulting in overuse of endianness convesion macros; - "bdp->s