On Fri, Apr 9, 2021 at 11:28 PM Jakub Kicinski wrote:
>
> On Fri, 9 Apr 2021 22:44:50 +0200 Matteo Croce wrote:
> > > What pops to mind (although quite nit picky) is the question if the
> > > assembly changes much between driver which used to cache nr_frags and
> > > now always going skb_shinfo(sk
Hi Matteo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Matteo-Croce/introduce-skb_for_each_frag/20210410-020828
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
44
On Fri, 9 Apr 2021 22:44:50 +0200 Matteo Croce wrote:
> > What pops to mind (although quite nit picky) is the question if the
> > assembly changes much between driver which used to cache nr_frags and
> > now always going skb_shinfo(skb)->nr_frags? It's a relatively common
> > pattern.
>
> Since
Hi Matteo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Matteo-Croce/introduce-skb_for_each_frag/20210410-020828
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
44
On Fri, Apr 9, 2021 at 8:54 PM Jakub Kicinski wrote:
>
> On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote:
> > From: Matteo Croce
> >
> > use the new helper macro skb_for_each_frag() which allows to iterate
> > through all the SKB fragments.
> >
> > The patch was created with Coccinelle, thi
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote:
> From: Matteo Croce
>
> use the new helper macro skb_for_each_frag() which allows to iterate
> through all the SKB fragments.
>
> The patch was created with Coccinelle, this was the semantic patch:
Bunch of set but not used warnings here.
From: Matteo Croce
use the new helper macro skb_for_each_frag() which allows to iterate
through all the SKB fragments.
The patch was created with Coccinelle, this was the semantic patch:
@@
struct sk_buff *skb;
identifier i;
statement S;
iterator name skb_for_each_frag;
@@
-for (i = 0; i < skb_
