Re: [PATCH net-next 2/3] net: phy: marvell10g: fix usage of new MMD modifying helpers

2019-02-10 Thread Florian Fainelli
Le 2/10/19 à 10:58 AM, Heiner Kallweit a écrit : > When replacing mv3310_modify() with phy_modify_mmd() we missed that > they behave differently, mv3310_modify() returns 1 on a changed > register value whilst phy_modify_mmd() returns 0. Fix this by replacing > phy_modify_mmd() with phy_modify_mmd_c

Re: [PATCH net-next 2/3] net: phy: marvell10g: fix usage of new MMD modifying helpers

2019-02-10 Thread Andrew Lunn
On Sun, Feb 10, 2019 at 07:58:49PM +0100, Heiner Kallweit wrote: > When replacing mv3310_modify() with phy_modify_mmd() we missed that > they behave differently, mv3310_modify() returns 1 on a changed > register value whilst phy_modify_mmd() returns 0. Fix this by replacing > phy_modify_mmd() with

[PATCH net-next 2/3] net: phy: marvell10g: fix usage of new MMD modifying helpers

2019-02-10 Thread Heiner Kallweit
When replacing mv3310_modify() with phy_modify_mmd() we missed that they behave differently, mv3310_modify() returns 1 on a changed register value whilst phy_modify_mmd() returns 0. Fix this by replacing phy_modify_mmd() with phy_modify_mmd_changed() where needed. Fixes: b52c018ddccf ("net: phy: m