Re: [PATCH net-next 2/3] net/sched: cls_flower: Classify packet in ip tunnels

2016-08-22 Thread Alexei Starovoitov
On Mon, Aug 22, 2016 at 07:05:23PM +0200, Jiri Benc wrote: > On Mon, 22 Aug 2016 17:38:33 +0300, Amir Vadai wrote: > > + if (tb[TCA_FLOWER_KEY_ENC_IPV6_SRC] || > > + tb[TCA_FLOWER_KEY_ENC_IPV6_DST]) > > + return -ENOTSUPP; > > Please add also support for IPv6. We've had enough of

Re: [PATCH net-next 2/3] net/sched: cls_flower: Classify packet in ip tunnels

2016-08-22 Thread Jiri Benc
On Mon, 22 Aug 2016 17:38:33 +0300, Amir Vadai wrote: > + if (tb[TCA_FLOWER_KEY_ENC_IPV6_SRC] || > + tb[TCA_FLOWER_KEY_ENC_IPV6_DST]) > + return -ENOTSUPP; Please add also support for IPv6. We've had enough of half-implemented stuff in tunneling and we need to really treat

[PATCH net-next 2/3] net/sched: cls_flower: Classify packet in ip tunnels

2016-08-22 Thread Amir Vadai
Introduce classifying by metadata extracted by the tunnel device. Outer header fields - source/dest ip and tunnel id, are extracted from the metadata when classifying. For example, the following will add a filter on the ingress Qdisc of shared vxlan device named 'vxlan0'. To forward packets with o