Hi Ioana,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Ioana-Ciornei/dpaa2-eth-add-rx-copybreak-support/20210402-05
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
0
On Thu, Apr 01, 2021 at 11:13:50PM +0300, Ioana Ciornei wrote:
> On Thu, Apr 01, 2021 at 08:49:43PM +0200, Andrew Lunn wrote:
> > Hi Ioana
> >
> > > +#define DPAA2_ETH_DEFAULT_COPYBREAK 512
> >
> > This is quite big. A quick grep suggest other driver use 256.
> >
> > Do you have some perfor
On Thu, Apr 01, 2021 at 08:49:43PM +0200, Andrew Lunn wrote:
> Hi Ioana
>
> > +#define DPAA2_ETH_DEFAULT_COPYBREAK512
>
> This is quite big. A quick grep suggest other driver use 256.
>
> Do you have some performance figures for this?
>
Hi Andrew,
Yes, I did some tests which made me
Hi Ioana
> +#define DPAA2_ETH_DEFAULT_COPYBREAK 512
This is quite big. A quick grep suggest other driver use 256.
Do you have some performance figures for this?
Andrew
From: Ioana Ciornei
DMA unmapping, allocating a new buffer and DMA mapping it back on the
refill path is really not that efficient. Proper buffer recycling (page
pool, flipping the page and using the other half) cannot be done for
DPAA2 since it's not a ring based controller but it rather deals w