Re: [PATCH net-next 2/2 v2] net sched actions: add time filter for action dumping

2017-04-18 Thread Jamal Hadi Salim
On 17-04-18 09:35 PM, Eric Dumazet wrote: On Tue, 2017-04-18 at 21:14 -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim + if (tcaa[TCAA_ACT_TIME_FILTER]) + msecs_filter = nla_get_u32(tcaa[TCAA_ACT_TIME_FILTER]); You forgot to add TCAA_ACT_TIME_FILTER in tcaa_polic

Re: [PATCH net-next 2/2 v2] net sched actions: add time filter for action dumping

2017-04-18 Thread Eric Dumazet
On Tue, 2017-04-18 at 21:14 -0400, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > + if (tcaa[TCAA_ACT_TIME_FILTER]) > + msecs_filter = nla_get_u32(tcaa[TCAA_ACT_TIME_FILTER]); You forgot to add TCAA_ACT_TIME_FILTER in tcaa_policy There is no guarantee user passed 32bit d

[PATCH net-next 2/2 v2] net sched actions: add time filter for action dumping

2017-04-18 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user space. With this patch the user sp