Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-28 Thread David Miller
From: Jakub Kicinski Date: Thu, 28 Sep 2017 06:59:12 -0700 > On Tue, 26 Sep 2017 08:35:22 -0700, Jakub Kicinski wrote: >> Add a simple tool for querying and updating BPF objects on the system. >> >> Signed-off-by: Jakub Kicinski >> Reviewed-by: Simon Horman > > Dave, I got some late review ni

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-28 Thread Jakub Kicinski
On Tue, 26 Sep 2017 08:35:22 -0700, Jakub Kicinski wrote: > Add a simple tool for querying and updating BPF objects on the system. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Dave, I got some late review nitpicks internally which I think are worth addressing. Would you mind d

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-27 Thread Markus Heiser
> Am 27.09.2017 um 13:19 schrieb Jesper Dangaard Brouer : [...] >>> I would prefer adding a README.rst file, in RST-format, as the rest of >>> the kernel documentation is moving in that direction[1] (your github >>> version is in README.md format). A man page will always be >>> out-of-sync, and e

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-27 Thread Jesper Dangaard Brouer
On Wed, 27 Sep 2017 03:57:42 -0700 Jakub Kicinski wrote: > On Wed, 27 Sep 2017 12:45:11 +0200, Jesper Dangaard Brouer wrote: > > On Wed, 27 Sep 2017 00:02:08 +0100 > > Jakub Kicinski wrote: > > > > > On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: > > > > On Tue, Sep 26, 201

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-27 Thread Jakub Kicinski
On Wed, 27 Sep 2017 12:45:11 +0200, Jesper Dangaard Brouer wrote: > On Wed, 27 Sep 2017 00:02:08 +0100 > Jakub Kicinski wrote: > > > On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: > > > On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: > > > > Add a simple tool

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-27 Thread Daniel Borkmann
On 09/27/2017 12:45 PM, Jesper Dangaard Brouer wrote: On Wed, 27 Sep 2017 00:02:08 +0100 Jakub Kicinski wrote: On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: Add a simple tool for querying and updating BPF objects

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-27 Thread Jesper Dangaard Brouer
On Wed, 27 Sep 2017 00:02:08 +0100 Jakub Kicinski wrote: > On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: > > On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: > > > Add a simple tool for querying and updating BPF objects on the system. > > > > > > Signed-off-by: J

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-26 Thread Jakub Kicinski
On Tue, 26 Sep 2017 15:24:06 -0700, Alexei Starovoitov wrote: > On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: > > Add a simple tool for querying and updating BPF objects on the system. > > > > Signed-off-by: Jakub Kicinski > > Reviewed-by: Simon Horman > > --- > > tools/bpf/Ma

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-26 Thread Alexei Starovoitov
On Tue, Sep 26, 2017 at 08:35:22AM -0700, Jakub Kicinski wrote: > Add a simple tool for querying and updating BPF objects on the system. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman > --- > tools/bpf/Makefile | 18 +- > tools/bpf/bpftool/Makefile | 80 + >

Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-26 Thread Daniel Borkmann
On 09/26/2017 05:35 PM, Jakub Kicinski wrote: Add a simple tool for querying and updating BPF objects on the system. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman LGTM, thanks! Acked-by: Daniel Borkmann

[PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-26 Thread Jakub Kicinski
Add a simple tool for querying and updating BPF objects on the system. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- tools/bpf/Makefile | 18 +- tools/bpf/bpftool/Makefile | 80 + tools/bpf/bpftool/common.c | 214 tools/bpf/bpftool/jit_disasm